Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump grpc to v1.56.2 v8 #2485

Merged
merged 1 commit into from Aug 23, 2023
Merged

Conversation

jaristiz
Copy link

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

Description of the Change

Bumping google.golang.org/grpc to v1.56.2

Why Is This PR Valuable?

Up-to-date version

Applicable Issues

How Urgent Is The Change?

Other Relevant Parties

@jaristiz jaristiz force-pushed the feat/bump-grpc-to-v1.56.2-v8 branch 2 times, most recently from da76325 to 9b0f4eb Compare July 12, 2023 18:06
@a-b
Copy link
Member

a-b commented Jul 13, 2023

@jaristiz I can see that you closed v7 backport PR. Can you please reopen it?

@jaristiz
Copy link
Author

jaristiz commented Jul 14, 2023

@jaristiz I can see that you closed v7 backport PR. Can you please reopen it?

That branch requires way more work as one of the grpc components changed its interface, that's the reason why I closed it, I could reopen it but manual work will need to be done in order to bump this dependency and our immediate urgency was to get v8 done, I will be doing that once we get this one approved.

@jaristiz jaristiz force-pushed the feat/bump-grpc-to-v1.56.2-v8 branch from 9b0f4eb to 3b048c8 Compare July 14, 2023 18:44
@jaristiz
Copy link
Author

@a-b this pipeline has been shown inconsistent results on the reruns for the pipelines, which for me, from the outside look like fakes, is there something I can do from my side to get it green?

@pabloarodas
Copy link
Contributor

@a-b is there something we can do to get this PR merged? We still need this bump to fix the CVEs in our smoke tests release.

Co-authored-by: Jhonathan Aristizabal <jhonathana@vmware.com>
@a-b a-b merged commit 8ade0e6 into cloudfoundry:v8 Aug 23, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants