Don't fetch unneeded pages (v8) #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce 'Page' query key - when set, stop automatic pagination - add 'PerPage' and 'Page' query keys to all list endpoints where only a single item from the returned list is used - use 'MakeListRequest' function in 'GetEvents' and set 'Page' query key in caller - adapt 'StagePackage' function to include 'GUIDFilter' instead of iterating over the returned package list and comparing guids
a-b
reviewed
Jan 17, 2024
a-b
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
@dalvarado and I reviewed this proposal and it looks good to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pagequery keyPerPageandPagequery keys to all list endpoints where only a single item from the returned list is usedMakeListRequestfunction inGetEventsand setPagequery key in callerStagePackagefunction to includeGUIDFilterinstead of iterating over the returned package list and comparing guidsFixes #2599