Add User-agent for repo-plugins api calls (#2722) #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add user agent info for plugin api calls * Remove comment * Edit error message * Use same user agent as api/plugin/client.go - would be nice to use command.config but we couldn't see an easy way to thread it Co-authored-by: david alvarado <alvaradoda@vmware.com> * Add test - The reason it is checking NotTo(Equal(...)) is because the default user agent "Go-http-client/1.1" is being blocked by the webserver Co-authored-by: david alvarado <alvaradoda@vmware.com> * Clean up deprecation and some warnings and regenerate fake_plugin_repo as we made changes --------- Co-authored-by: M. Oleske <moleske@pivotal.io> Co-authored-by: david alvarado <alvaradoda@vmware.com> Co-authored-by: Al Berez <a-b@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add user agent info for plugin api calls
Remove comment
Edit error message
Use same user agent as api/plugin/client.go
Thank you for contributing to the CF CLI! Please read the following:
cherry-pick of #2722
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Where this PR should be backported?
Description of the Change
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?