Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use latest untested capi v7 #2772

Merged
merged 2 commits into from Feb 5, 2024
Merged

Conversation

moleske
Copy link
Member

@moleske moleske commented Feb 2, 2024

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Where this PR should be backported?

  • main - all changes should by default start here
  • v8
  • v7

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

moleske and others added 2 commits February 2, 2024 13:54
- the latest capi being deployed was from the capi job [create-capi-release](https://ci.capi.land/teams/main/pipelines/capi/jobs/create-capi-release/builds/1531) which is untested
- this has previously led to issues where the capi version was failing
- this change will just use whatever is in cf-d as that is the capi that has been tested and passing
Co-authored-by: Al Berez <al.berez@broadcom.com>
Copy link

CLA Not Signed

@moleske
Copy link
Member Author

moleske commented Feb 5, 2024

/easycla

@moleske moleske merged commit 68f19d6 into v7 Feb 5, 2024
12 of 13 checks passed
@moleske moleske deleted the do-not-use-latest-untested-capi-v7 branch February 5, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant