Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appGUID attribute to droplet resource #2801

Closed
wants to merge 1 commit into from

Conversation

gmllt
Copy link
Member

@gmllt gmllt commented Mar 1, 2024

Where this PR should be backported?

Description of the Change

The V3 API allows you to access to the relationships existing beween a droplet and its related app.
This PR make this relationship visible trough a new AppGUID attribute in the resource droplet.

The community cf_exporter currently use the /v2/spaces/:guid/summary endpoint to gain access to buildpack associated to an application. Have this relationship visible would help get rid of calls on this endpoint and retrieve buildpacks attached to an application through its droplets.

This feature is necessary for applications using the cli product in go development to established relationship between an application resource and its droplets.

This feature will not cause breaking change.

@a-b
Copy link
Member

a-b commented Mar 22, 2024

@gmllt can you please create PR for the main branch?

@gmllt
Copy link
Member Author

gmllt commented Mar 28, 2024

@a-b sorry for the delay, here is the PR on the main branch

@moleske moleske force-pushed the add-droplets-relationships branch from f5348e3 to a774c76 Compare April 4, 2024 05:28
@moleske
Copy link
Member

moleske commented Apr 4, 2024

The integration tests seemed sad due to the switch from ginkgo v1 to ginkgo v2. I've rebased your branch and pushed it up to get things running again

@gururajsh
Copy link
Member

@gmllt We had some environment issues and integration tests did not run. Can you please update the branch and reopen the PR?

@gmllt gmllt force-pushed the add-droplets-relationships branch from a774c76 to e43b64d Compare May 17, 2024 12:45
@gmllt
Copy link
Member Author

gmllt commented May 17, 2024

recreating new PR

@gmllt
Copy link
Member Author

gmllt commented May 17, 2024

new PR : 2932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants