V8: Ginkgo v2 additional changes #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add user agent info for plugin api calls - Newer lager was needed with newer diego-ssh * Replace depracted ginkgo calls with non deprecated calls * Remove ACK_GINKGO_RC * Desperate attempt at resolving output issue by using serial decorator and using non deprecated pty * Turn off Gingkno v2 parallel mode * Adjust integration tests to use ginkgo v2 * Add Byte to lograte, disk and memory regexes used by int tests --------- Co-authored-by: M. Oleske <moleske@pivotal.io> Co-authored-by: Al Berez <al.berez@broadcom.com> Co-authored-by: Cristhian Peña <ccjaimes@users.noreply.github.com> Co-authored-by: Marc Paquette <marc.paquette@broadcom.com>
When we ran Ginkgo v2 tests for the first time we got the following
error:
```
go install github.com/onsi/ginkgo/v2/ginkgo
go install github.com/onsi/gomega/matchers
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
go: downloading github.com/onsi/ginkgo/v2 v2.15.0
go: downloading github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572
go: downloading golang.org/x/tools v0.17.0
go: downloading github.com/google/pprof v0.0.0-20230912144702-c363fe2c2ed8
missing go.sum entry for module providing package github.com/onsi/gomega/matchers; to add:
go mod download github.com/onsi/gomega
Error: Process completed with exit code 1.
```
Update deprecated v1 calls to use v2
a-b
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the CF CLI! Please read the following:
If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
Where this PR should be backported?
Description of the Change
Replaced deprecated ginkgo v1 references with v2 ones.
We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.
Why Is This PR Valuable?
What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?
Applicable Issues
List any applicable GitHub Issues here
How Urgent Is The Change?
Is the change urgent? If so, explain why it is time-sensitive.
Other Relevant Parties
Who else is affected by the change?