Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version check to CLAW update [v8] #2907

Merged
merged 8 commits into from
May 23, 2024
Merged

Add version check to CLAW update [v8] #2907

merged 8 commits into from
May 23, 2024

Conversation

gururajsh
Copy link
Member

Description of the Change

Before updating CLAW with new release version, make sure the new version is not already present in the list. If the new version already exists, then something has gone wrong with the release process, so it exits.

Why Is This PR Valuable?

Prevents duplicate entries to CLAW.

Applicable Issues

List any applicable GitHub Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

@gururajsh gururajsh requested a review from a-b May 10, 2024 15:03
@gururajsh gururajsh changed the title Add version check to CLAW update Add version check to CLAW update [v8] May 10, 2024
Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider suggestions above

.github/workflows/release-build-sign-upload.yml Outdated Show resolved Hide resolved
@gururajsh gururajsh requested a review from moleske May 13, 2024 15:26
Copy link
Member

@moleske moleske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like a reasonable approach to me

@gururajsh
Copy link
Member Author

Thank you @moleske .

Copy link
Member

@a-b a-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a-b a-b merged commit 481c7e3 into cloudfoundry:v8 May 23, 2024
13 checks passed
a-b added a commit that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants