Fix ui.Ask to return strings with spaces from stdin #299
Conversation
|
Hey uzzz! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/82840504. |
| @@ -68,6 +68,15 @@ var _ = Describe("UI", func() { | |||
| }) | |||
| }) | |||
|
|
|||
| Describe("Asking user for input", func() { | |||
| It("allows string with witespaces", func() { | |||
There was a problem hiding this comment.
witespaces should be whitespaces
|
Hi @uzzz, Unfortunately we are unable to merge PR's without you signing a CLA. If you belong to an organization that has already signed one all you have to do is make your membership to that organization public. This does look like a good change to make! Would you mind adding a test for when ReadString() returns an error? We commented on the single spelling mistake as well :). Thanks for the PR! The CLI Team |
|
Hi, thanks for response. |
|
I want to join up in this project but unfortunately, I am a newbie. Which fixes would you recommend for me. |
Fix ui.Ask to return strings with spaces from stdin (fixes cloudfoundry#264 on github)
|
@drich10 hi again. Finally I figured out that my company already signed corporate CLA – I'm a new member of Altoros. Here you can see my membership – https://github.com/orgs/Altoros/people |
Fix ui.Ask to return strings with spaces from stdin
Hi.
I'm happy to help with it. The issue was in ui.Ask method, which used for windows terminal ui implementation (and there's a custom implementation for unix terminal ui). I think it's a good idea to fix this method, not just windows password prompt because in theory other prompts could contain spaces (such as login for instance).