Enforce service name uniqueness in shared services in spaces #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brandon Potts <bpotts@vmware.com> Co-authored-by: Seth Boyles <sboyles@pivotal.io> Co-authored-by: Jenna Goldstrich <jgoldstrich@pivotal.io> This commit prevents a space from being shared if it contains a service instance whose name is already in use in the target space. This commit resolves GitHub issue #2306 This commit is a retry of a previous commit. Co-authored-by: Brandon Potts <bpotts@vmware.com> Co-authored-by: Seth Boyles <sboyles@pivotal.io> Fix issue in unit tests where target_space would no longer update its list of shared_services Remove test that validated idempotant service_instance creates, this is no longer valid as we are changing them to enforce name uniqueness Authored-by: Jenna Goldstrich <jgoldstrich@pivotal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2306
Tested this locally on a bosh lite using the repro steps in the above issue,
Locally rake bundle exec rake spec and it passed.
Co-authored-by: Brandon Potts bpotts@vmware.com
Co-authored-by: Seth Boyles sboyles@pivotal.io
Co-authored-by: Jenna Goldstrich jgoldstrich@pivotal.io