Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce service name uniqueness in shared services in spaces #2521

Merged
merged 1 commit into from
Sep 29, 2021

Commits on Sep 28, 2021

  1. Enforce service name uniqueness in shared services in spaces

    Co-authored-by: Brandon Potts <bpotts@vmware.com>
    Co-authored-by: Seth Boyles <sboyles@pivotal.io>
    Co-authored-by: Jenna Goldstrich <jgoldstrich@pivotal.io>
    
    This commit prevents a space from being shared if it contains a
    service instance whose name is already in use in the target space.
    
    This commit resolves GitHub issue #2306
    
    This commit is a retry of a previous commit.
    
    Co-authored-by: Brandon Potts <bpotts@vmware.com>
    Co-authored-by: Seth Boyles <sboyles@pivotal.io>
    
    Fix issue in unit tests where target_space would no longer update its
    list of shared_services
    
    Remove test that validated idempotant service_instance creates, this is
    no longer valid as we are changing them to enforce name uniqueness
    
    Authored-by: Jenna Goldstrich <jgoldstrich@pivotal.io>
    bepotts authored and Jenna Goldstrich committed Sep 28, 2021
    Configuration menu
    Copy the full SHA
    114fef7 View commit details
    Browse the repository at this point in the history