Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter out quota metrics #2670

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Don't filter out quota metrics #2670

merged 1 commit into from
Feb 8, 2022

Conversation

ctlong
Copy link
Member

@ctlong ctlong commented Feb 8, 2022

Allows app quota retrieval when metrics are delivered in separate envelopes, which occurs when syslog ingress to log cache is turned on.

Closes #2669.

  • I have reviewed the contributing guide

  • I have viewed, signed, and submitted the Contributor License Agreement

  • I have made this pull request to the main branch

  • I have run all the unit tests using bundle exec rake

  • I have run CF Acceptance Tests

Co-authored-by: Carson Long <lcarson@vmware.com>
@ctlong
Copy link
Member Author

ctlong commented Feb 8, 2022

I deployed this change in a CF-D environment that had syslog ingress to Log Cache turned on, and saw the app quotas reappear.

Copy link
Contributor

@sweinstein22 sweinstein22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App quotas not retrieved when Log Cache has syslog ingress turned on
4 participants