Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service_guid and service_url to service instance entity #701

Merged
merged 1 commit into from
Nov 9, 2016

Conversation

jeffpak
Copy link
Contributor

@jeffpak jeffpak commented Oct 20, 2016

Thanks for contributing to the cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

Allow users access to a service instance's service offering without having to go through the service plans endpoint.

  • An explanation of the use cases your change solves
  1. You no longer have to go through an additional endpoint to hit a service instance's service offering.
  2. If a service instance's plan is private, you can more easily find its service offering through one direct endpoint.
  • I have viewed signed and have submitted the Contributor License Agreement
  • I have made this pull request to the master branch
  • I have run all the unit tests using bundle exec rake
  • I have run CF Acceptance Tests on bosh lite
  • This lets users access a service instance's service offering
    without having to go through its service plan. This does not
    introduce a database migration.

[#130772287]

- This lets users access a service instance's service offering
  without having to go through its service plan. This does not
  introduce a database migration.

[#130772287]
@cfdreddbot
Copy link

Hey jeffpak!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/132867779

The labels on this github issue will be updated when the story is started.

@jeffpak
Copy link
Contributor Author

jeffpak commented Oct 21, 2016

This is my output from the command:

screen shot 2016-10-20 at 5 38 56 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants