feat: mssql storage type extra #185149472 #1061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#185149472]
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185779669 The labels on this github issue will be updated when the story is started. |
fnaranjo-vmw
changed the title
[#185149472] So far, other services preferred ignoring iops field when storage type was not io1 or gp3. This implementation raises error instead. The reasoning is to follow the principle of least surprise. If a specific combination is invalid, enforce users to clearly specify correct values. There is some level of surprise though, because iops is 3000 by default, so a customer might not be aware of this and still get the error. However, even in that case, it might be useful to surface the error to make the default value explicit and evident.
fnaranjo-vmw
force-pushed
the
feat-mssql-storage-type-extra-#185149472
branch
from
0ed5016
to
bad6fa7
Compare
2 tasks
[#185149472] Terraform already checks more combinations than us, and do it fast without having to wait for an error from th IAAS. Removing these redundant and incomplete validations. Also allowed iops to be set to null. This is to allow customers to override the default iops value, in case they want to use a non-iops based storage_type such as gp2 or standard.
fnaranjo-vmw
force-pushed
the
feat-mssql-storage-type-extra-#185149472
branch
from
830260d
to
75e214e
Compare
[#185149472] They must have ended-up in the wrong test by accident.
|
Added @servicesenablement as a reviewer to prevent this PR from appearing in Slack Code Review bot messages. |
fnaranjo-vmw
added
enhancement
|
Closed due to no recent activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1060.
It suggests a different approach to the
iopsandstorage_typeinterdependency.Instead of masking some invalid combinations from the user, let every invalid
combination fail with descriptive messages.
This PR requires a team discussion and the approval of the whole team to be merged.
Checklist: