Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mssql storage type extra #185149472 #1061

Closed
wants to merge 5 commits into from

Commits on Aug 7, 2023

  1. feat: Enable changing storage type

    [#185149472]
    fnaranjo-vmw committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    c64ce5f View commit details
    Browse the repository at this point in the history
  2. feat: [MSSQL] dont mask invalid iops combinations

    [#185149472]
    
    So far, other services preferred ignoring iops field when storage
    type was not io1 or gp3. This implementation raises error instead.
    
    The reasoning is to follow the principle of least surprise. If a
    specific combination is invalid, enforce users to clearly specify
    correct values.
    
    There is some level of surprise though, because iops is 3000 by
    default, so a customer might not be aware of this and still get
    the error. However, even in that case, it might be useful to
    surface the error to make the default value explicit and evident.
    fnaranjo-vmw committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    bad6fa7 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. fix: [MSSQL] remove unnecessary validations

    [#185149472]
    
    Terraform already checks more combinations than us, and do it
    fast without having to wait for an error from th IAAS.
    Removing these redundant and incomplete validations.
    
    Also allowed iops to be set to null. This is to allow customers
    to override the default iops value, in case they want to use
    a non-iops based storage_type such as gp2 or standard.
    fnaranjo-vmw committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2555943 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    75e214e View commit details
    Browse the repository at this point in the history
  3. fix: [MSSQL] storage_type and iops can be updated

    [#185149472]
    
    They must have ended-up in the wrong test by accident.
    fnaranjo-vmw committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    cb0b579 View commit details
    Browse the repository at this point in the history