fix: issue where Storage binding parameters do not work with Spring #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCP Cloud Foundry Environment Post Processor needs specific service names and property key names when reading the binding credentials. See example: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/d8d7168e57683adf76b1e56b1a3e7d87fb7d8bdf/spring-cloud-gcp-cloudfoundry/src/main/java/com/google/cloud/spring/cloudfoundry/GcpCloudFoundryEnvironmentPostProcessor.java#L164 [#187565525](https://www.pivotaltracker.com/story/show/187565525)
We want to be able to test the application locally, for this we need to overwrite the environment variable VCAP_SERVICES and overwrite the environment processor. We’ll also need to mock the oAuth the Google service. We’ll leave it for the next phase of development, so we delete the unnecessary dependencies [#187565525](https://www.pivotaltracker.com/story/show/187565525)
blgm
reviewed
May 27, 2024
...in/java/broadcom/spring/gcp/object/storage/gcpobjectstorage/GcpobjectstorageApplication.java
Outdated
Show resolved
Hide resolved
FelisiaM
reviewed
May 28, 2024
FelisiaM
reviewed
May 28, 2024
...in/java/broadcom/spring/gcp/object/storage/gcpobjectstorage/GcpobjectstorageApplication.java
Outdated
Show resolved
Hide resolved
GCP Cloud Foundry Environment Post Processor needs specific service names and property key names when reading the binding credentials. See example: https://github.com/GoogleCloudPlatform/spring-cloud-gcp/blob/d8d7168e57683adf76b1e56b1a3e7d87fb7d8bdf/spring-cloud-gcp-cloudfoundry/src/main/java/com/google/cloud/spring/cloudfoundry/GcpCloudFoundryEnvironmentPostProcessor.java#L164 [#187565525](https://www.pivotaltracker.com/story/show/187565525)
We want to be able to test the application locally, for this we need to overwrite the environment variable VCAP_SERVICES and overwrite the environment processor. We’ll also need to mock the oAuth the Google service. We’ll leave it for the next phase of development, so we delete the unnecessary dependencies [#187565525](https://www.pivotaltracker.com/story/show/187565525)
zucchinidev
force-pushed
the
fix_storage_binding_parameters_with_spring
branch
from
282102f
to
4ec06e9
Compare
blgm
approved these changes
May 28, 2024
There was a problem hiding this comment.
This is great @zucchinidev. I ran the test, and particularly liked that it compiled all the Java stuff for me without me having to do any manual steps.
GoLang is the name of a web page [#187565525](https://www.pivotaltracker.com/story/show/187565525)
…om:cloudfoundry-incubator/csb-brokerpak-gcp into fix_storage_binding_parameters_with_spring
…arameters_with_spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP Spring Cloud Foundry Environment Post Processor needs specific service names and property key names when reading the binding credentials.
See example here
#187565525
Checklist: