-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding a bosh property to customize TerminateTimeout #363
Comments
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/151464387 The labels on this github issue will be updated when the story is started. |
As an optional bonus it would be nice if some logging were added so we could monitor applications that have instances killed via sigkill. There is a debug message today, I think an info message to that effect with app identifiable information would be very helpful. |
Hey, @youngm, thanks for starting this discussion on Slack a while ago. I've just added https://www.pivotaltracker.com/story/show/152431251 for the Diego team to prioritize soon; could you let me know if you have any feedback about it? Thanks, |
Thanks for keeping this issue going @emalm I think the story looks great. A couple of side questions:
|
@emalm Nice work with this issue! I think you delivered exactly what I'm looking for. We'll get this value into our next release and start gathering some useful data. |
Hey, thanks, @youngm ! We'd really appreciate some feedback on it from you and your devs. Oh, I still owe you answers to your questions above -- I'll try to do that soon, and certainly before we close out this issue. Thanks again, |
Regarding your earlier questions, @youngm:
Hope that helps! I'll close this issue out, but as always I'm happy to continue discussion on GitHub or in Slack. Thanks, |
Oh, for posterity, we delivered this configurability in Diego v1.32.0. |
That was great! Thank you @emalm . I do have users who regularly use "restart-app-instance" as a way to do a kind of rolling restart for various reasons. Once we have a real rolling restart solution then I suspect we won't use this feature for that reason anymore. Nobody has noticed the current issue with restart-app-instance so from my perspective I would give it a low priority and instead look towards rolling restart. Hope that helps! Mike |
Hey, @youngm, Interesting, do you know what those reasons are? On the DEAs, that rolling Thanks, |
@emalm @zrob yeah, I think there was some of that in the DEA world. But like you said that wouldn't work in the Diego world. (Though I think many people may not yet realize that) The only other reasons would be application specific reasons. For example, could be used as a poor man's cache flush or reloading of configuration not supplied via service credentials. In addition, operators may occasionally use that tool to help balance Cell load across the cluster after a deploy. In general mostly used as a hack or workaround where better solutions but the development teams haven't gotten around to solving. Nothing in my mind worth prioritizing https://www.pivotaltracker.com/story/show/153437108 very high. |
[finishes #163037208](https://www.pivotaltracker.com/story/show/163037208) Submodule src/code.cloudfoundry.org/executor 325be3662..b67be5e6e: > Merge branch 'pr/41' Submodule src/github.com/envoyproxy/go-control-plane 000000000...8a91fb26f (new submodule) Submodule src/github.com/gogo/googleapis 000000000...8558fb44d (new submodule) Submodule src/github.com/gogo/protobuf f9114dace..4cbf7e384: > Merge pull request #528 from jmarais/mergeaa810b6 > merged in golang/protobuf commit 7d1b268556d691919f2262240737157830eab632 - jsonpb: avoid unexported fields in hand-crafted message (#526) > merged in golang/protobuf commit f5983d50c82d70eaa88c17080245cc871558081f - proto: make invalid UTF-8 errors non-fatal (#525) > merged in golang/protobuf commit 560bdb64431cc123098c2db67f16053a923a0688 - jsonpb: strictly document JSONPBMarshaler and JSONPBUnmarshaler behavior (#524) > merged in golang/protobuf commit 93b26e6a70e37abb14f2f88194949312b0592a84 - protoc-gen-go: refactor generator by splitting up generateMessage > Merge pull request #522 from jmarais/somemerges > use only one write in the varint writer when possible (#504) > fix typo independant to independent (#512) > Add godocs link to Readme.md (#506) > Fix text unmarshal for (u)int(8/16) fields (#498) > Codegen for well-known types (#489) > reorder some of the protoc paths in order to prefer our protobuf/google/protobuf/*.proto files. This is just to avoid using the wrong protos if you have the same protos in you gopath/src dir. (#502) > fix error: bad Go source code was generated, illegal hexadecimal number (#488) > Jsonpb custom type - #411 (#491) > Customtype Warnings and issues update (#479) > Exact slice allocation for repeated packed varints (#480) > Adding missing func to CustomType documentation (#483) > bumped the go version (#475) > added nil check in Proto/Size methods fix #444 (#451) > fix for letmegrpc (#474) > options to not generate xxx fields (#467) > updated to go1.11 and removed go1.9 (#473) > merged in golang/protobuf commit 70c277a8a150a8e069492e6600926300405c2884 - Fix unmarshaling JSON object with escaped string into Struct type. (#464) > merge in golang/protobuf commit 3a3da3a4e26776cc22a79ef46d5d58477532dede - proto: mention field name in error message (#616) (#465) > added license details to Readme.md (#469) > Update Readme.md (#468) > Set defaults on nonnullable fields (#435) (#459) > removed the GOPATH env dep in the makefile protopath (#461) > Merge pull request #455 from donaldgraham/master > Fix nullable extension issues for non generated code (#453) > Fix wrong build tags (#445) > merged commit 32a84b27e28ab9f681f0df16160c4ef1f6587094 from golang/pr… (#446) > Added ProtoSize wrapper functions for the well known types #438 (#443) > exact slice allocation for fixed size packed fields (#437) > Added gRPC Course on Udemy (#434) > Update Readme.md > Fix typo (#441) > fix #427 consistent import naming between the import declaration and the vars in grpc > fix build by regenerating everything > fix git diff for travis > merged 7c4add53b497798e7fd7b204f28e41ab409bdbb7 from golang/protobuf. protoc-gen-go: remove deprecated function in grpc (#426) > merged 3fac2a27c94f99f4379551928df388fcb0ad37ce from golang/protobuf. ptypes: optimize Is to avoid prefix scan (#425) > Merge pull request #424 from gogo/dev > gofmt > travis: opt into apt get > messagename > grpc error usage article > add mentions from Johan Brandhorst > merge bbd03ef6da3a115852eaf24c8a1c46aeb39aa175 from golang/protobuf > upgrade to go1.10 > fix build for gopherjs that now requires go 1.10 > fix build > fix for issue 389: importing of customtypes that are messages should not cause another import for the original message > Update Readme.md > add new user : go-spacemesh > protoc-min-version don't suppress protoc stdout and stderr out on success. (#381) > Update Readme.md > More well known types (#378) > Added link to new blog post in README (#375) > merge 925541529c1fa6821df4e44ce2723319eb2be768 from golang/protobuf > Added instructions for using proto files from google/protobuf (#371) > another user: zero stor > Update to protobuf 3.5.1 and minor cleanups for Golang 1.10 (#363) > Test with latest Go and protobuf patch versions. (#352) > Merge pull request #361 from temoto/lint-equal-return > Merge pull request #357 from benesch/populate-recursion > example > Merge pull request #355 from agnivade/agnivade-protopath > Merge pull request #341 from meling/master > fix for testdata/my_test > Merge pull request #350 from tomwilkie/go_package > Merge pull request #345 from Starnop/master > min version 3 for my_test/test.proto > Update extensions.md > merged 130e6b02ab059e7b717a096f397c5b60111cae74 from golang/protobuf > updated descriptor > merged 11b8df160996e00fd4b55cbaafb3d84ec6d50fa8 from golang/protobuf > merged 17ce1425424ab154092bbb43af630bd647f3bb0d from golang/protobuf > merged 5afd06f9d81a86d6e3bb7dc702d6bd148ea3ff23 from golang/protobuf > Merge pull request #343 from gogo/nounsafe > Merge branch 'master' of https://github.com/gogo/protobuf > fix mixbench > fix for issue 330 > remove unset GOROOT > different unset method > unset GOROOT > update gopherjs > go1.9 for gopherjs > upgrade descriptor and other includes > protoc3.4 > Merge branch 'master' of https://github.com/gogo/protobuf > less go versions > upgrade to go1.9 > nullable = false for defaults as well > merged 1909bc2f63dc92bb931deace8b8312c4db72d12f from golang/protobuf > merged 748d386b5c1ea99658fd69fe9f03991ce86a90c1 from golang/protobuf > merged 0a4f71a498b7c4812f64969510bcb4eca251e33a from golang/protobuf > merged 4f95b0d3eab845462f9b0ca5ad21dea8093be211 from golang/protobuf > merged 5a0f697c9ed9d68fef0116532c6e05cfeae00e55 from golang/protobuf > merged 6e4cc92cc905d5f4a73041c1b8228ea08f4c6147 from golang/protobuf > merged 9f174c986221c608fb5143bd623b6076a71feae3 from golang/protobuf > merge 7b8002443fd4a3ce5f25ef93087c524546799a56 from golang/protobuf > merge 63bfc7087234061252151bf2276a9db446645bb9 from golang/protobuf > Fix unmarshal to correctly handle default value in maps (#318) > Fix a race when using TextMarshal on a StdDuration (#290) > another gostring fix for non nullable repeated types > fix for issue 312 > hacks to reproduce a failing GoString test > trying to reproduce issue 312 > Update Readme.md > more consistent marshal/unmarshal behavior for types that implement json Marshaler and Unmarshaler interfaces (#308) > Update Readme.md > Update Readme.md > Update Readme.md > remove tags of typedecl=false and add JsonPBMarshalers and Unmarshaler implementations > fix:305 only serialize protofields (#307) > Update Readme.md > Update Readme.md > Merge branch 'master' of https://github.com/gogo/protobuf > doc.go file in sizerconflict > merged 7a211bcf3bce0e3f1d74f9894916e6f116ae83b4 from golang/protobuf > merged a4e8f93323fcf2bc1ae5c036dc4d973872057936 from golang/protobuf > upgrade to proto3.3 and merge 157d9c53be5810dd5a0fac4a467f7d5f400042ea and fec3b39b059c0f88fa6b20f5ed012b1aa203a8b4 from golang/protobuf > merged 47eb67eaf5cab63c58956d4d4ce86b03ad5eaa03 from golang/protobuf follow the new code generation comment convention > merged b50ceb1fa9818fa4d78b016c2d4ae025593a7ce3 from golang/protobuf > disable Any with Message for go1.7 > merged 18c9bb3261723cd5401db4d0c9fbc5c3b6c70fe8 from golang/protobuf > Update extensions.md > removed go1.6.3 from continious testing > Merge branch 'master' of https://github.com/gogo/protobuf > install protoc script modified to rather download precompiled protoc for versions which has this available > protoc 3.2.0 (#280) > skip unsafe tests for bigendian architectures. (#272) > Compile time warning when both Sizer and Protosizer are used (#271) > Add dual registration plugin (#270) > better mesos-go link > fixed mesos-go sample link > a real fix for issue261 > Merge branch 'master' of https://github.com/gogo/protobuf > fixes issue 261 > fix broken build > fix for issue 262 > Remove unnecessary statement (#263) > Add references to some custom imports (#258) > new user protoactor-go > Unrendered markdown (#256) > Drop types declaration option (#250) > fix for issue 253 gostring for stdtime and stdduration when nullable=false Submodule src/github.com/lyft/protoc-gen-validate 000000000...a11cd25ca (new submodule) Co-authored-by: Sunjay Bhatia <sbhatia@pivotal.io>
bump auction auctioneer bbs buildpackapplifecycle bytefmt cacheddownloader cfdot diego-ssh dockerapplifecycle dockerdriver ecrhelper executor fileserver goshims healthcheck inigo localdriver locket operationq rep route-emitter routing-api routing-info systemcerts trace-logger vizzini volman workpool garden grootfs guardian idmapper Submodule src/code.cloudfoundry.org/auction f4db6c51a..20b5e4eb0: > Bump to ginkgo/v2 and lager/v3 (#10) Submodule src/code.cloudfoundry.org/auctioneer 7b69d26e0..6757f6637: > Bump to ginkgo/v2 and lager/v3 (#11) Submodule src/code.cloudfoundry.org/bbs 952b49bde..41bd09f9f: > fix for `go vet` failures (#63) > Bump to lager/v3 (remaining) > Bump sqldb/helpers + test helpers to lager v3 (#61) > Bump to ginkgo/v2 Submodule src/code.cloudfoundry.org/buildpackapplifecycle 9bfd77998..b3c0aa499: > Merge pull request #61 from cloudfoundry/with-ginkgo-v2 > Merge pull request #59 from cloudfoundry/develop Submodule src/code.cloudfoundry.org/cacheddownloader 456a733fa..3de1f8d2e: > Bump to ginkgo/v2 and lager/v3 (#23) Submodule src/code.cloudfoundry.org/cfdot f68fa7f78..9c6e1b442: > Bump to ginkgo/v2 and lager/v3 (#6) Submodule src/code.cloudfoundry.org/diego-ssh 0fc4f3a7d..1003fb588: > Bump to ginkgo/v2 and lager/v3 (#47) Submodule src/code.cloudfoundry.org/dockerapplifecycle 163faedf6..36aa90971: > Bump to ginkgo/v2 (#11) > Regenerate test certificates Submodule src/code.cloudfoundry.org/dockerdriver 16e1fe9ba..76bff1bc5: > Bump to ginkgo/v2 and lager/v3 (#3) > Update PULL_REQUEST_TEMPLATE.md > content change Submodule src/code.cloudfoundry.org/ecrhelper 9a7c7e5a9..3949c0207: > Bump to ginkgo/v2 (#2) Submodule src/code.cloudfoundry.org/executor 1e5a6f15b..208a08c51: > With ginkgo v2 and lager/v3 (#75) > Ensure we release info lock when marshaling fails > Update garden container logging tags > Fix typo in function name > Fetch all containers for cleanup > Executor releases resources only when a container is successfully deleted Submodule src/code.cloudfoundry.org/fileserver 11af6ea87..f3dfda90a: > Bump to ginkgo/v2 && lager/v3 (#7) Submodule src/code.cloudfoundry.org/goshims bb24d2ef7..cf8c6ba6c: > Bump golang.org/x/net from 0.7.0 to 0.8.0 (#24) > Bump golang.org/x/net from 0.0.0-20200301022130-244492dfa37a to 0.7.0 (#23) > Bump github.com/go-sql-driver/mysql from 1.6.0 to 1.7.0 (#22) > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#21) > Revert "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19)" (#20) > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19) > Merge pull request #18 from cloudfoundry/dependabot/add-v2-config-file > Merge pull request #17 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.36.0 > Merge pull request #16 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.35.0 > Merge pull request #15 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.1 > Merge pull request #14 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.0 > Merge pull request #13 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.2 > Merge pull request #12 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.1 > Merge pull request #11 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.32.0 > Merge pull request #10 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.1 > Merge pull request #9 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.0 > Merge pull request #8 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.30.0 > go mod vendor > Merge pull request #7 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.29.1 > 🤖 go mod vendor > go get -u all > Add gitignore file > Convert to go modules > Add SetEnv to the command interface Submodule src/code.cloudfoundry.org/healthcheck d7f787b20..7670cbf97: > Bump to ginkgo/v2 (#9) Submodule src/code.cloudfoundry.org/inigo 18bab030e..3c8b1a8f8: > Bump to ginkgo/v2 & lager/v3 (#25) Submodule src/code.cloudfoundry.org/localdriver 1b0a47b1c..0668dcc60: > Bump to ginkgo/v2 & lager/v3 (#2) Submodule src/code.cloudfoundry.org/locket 76a930295..5e8522d97: > {fake_runner,fake_runner_v2} to be used with (#14) > Add BeforeSuite in the right place > Fix govet errors > Bump to lager v3 > WIP - upgrading to ginkgo v2+ ginkgomon_v2 Submodule src/code.cloudfoundry.org/operationq da3eb228f..4522d0860: > Bump to ginkgo/v2 (#2) > Fix the test for max capacity > Ginkgo v2: don't use Done channels > Update PULL_REQUEST_TEMPLATE.md > content change Submodule src/code.cloudfoundry.org/rep be8beeb46..f627e21dd: > Bump to ginkgo/v2 && lager/v3 (#39) Submodule src/code.cloudfoundry.org/route-emitter c907cd8f6..da039b0c1: > Bump to ginkgo/v2 && lager/v3 (#21) Submodule src/code.cloudfoundry.org/routing-api ff096da8d..2bf566855: > Fix ginkgo deprecations with Done channels > Fix ginkgo v2 flag deprecation notices > Bump to lager v3 > Convert to ginkgo v2 + inline the archived trace package > Convert to ginkgo v2 + inline the archived trace package > ignore .test files in the repo > Bump to ginkgo/v2 > Bump to ginkgo/v2 - WIP > Allow uaaclient callers to optionally pass in a protocol via (#30) Submodule src/code.cloudfoundry.org/routing-info 7d023ecb0..c6998d604: > Bump to ginkgo/v2 Submodule src/code.cloudfoundry.org/systemcerts 95ea366d9..5244fcb1b: > refactor: rm use of internal/testenv Submodule src/code.cloudfoundry.org/vizzini a59096109...6474f903a: > fix `go vet` failures > Bump to ginkgo/v2 && lager/v3 < Fix one more test using metric tags Submodule src/code.cloudfoundry.org/volman 4129b3172..76091d503: > Bump to ginkgo/v2 && lager/v3 (#5) Submodule src/code.cloudfoundry.org/workpool e8b9128ee..2e26d5d93: > Bump to ginkgo/v2 (#2) > Update PULL_REQUEST_TEMPLATE.md > content change Submodule src/garden d57de807d..8534099e1: > Migrate to lager v3 > Migrate to ginkgo/v2 > Bump lager to latest on master > Revert "bump ginkgo to v2 and lager to v3" > Merge pull request #107 from xtremerui/bump-ginkgo-lager > Bump golang.org/x/net from 0.0.0-20210428140749-89ef3d95e781 to 0.7.0 > Merge pull request #105 from cloudfoundry/unpin-components > Merge pull request #103 from ebroberson/ginkgov2-done-channels Submodule src/grootfs ba02da43d..df476b3ba: > Swtch to channels from pool > Return to pool xfs mounts that don't cause test pollution > Generate 10 mount points for all quota tests > Use unique mount directory for each test > Merge pull request #197 from cloudfoundry/with-ginkgo-v2 > go mod tidy && vendor > Bump lager to latest on master > 🔒 dep > Merge pull request #196 from cloudfoundry/unpin-components > Bump golang.org/x/sys from 0.5.0 to 0.6.0 > go mod tidy > Merge remote-tracking branch 'local/dependabot/go_modules/code.cloudfoundry.org/lager-2.0.0incompatible' into main > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/containers/image/v5-5.24.2' into main > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/docker/docker-23.0.1incompatible' into main > Merge remote-tracking branch 'local/dependabot/go_modules/golang.org/x/sys-0.5.0' into main > Bump github.com/opencontainers/runtime-spec > Merge pull request #191 from cloudfoundry/out-of-disk-error-with-jammy Submodule src/guardian 913b899bc..86f0a7d78: > Set container properties before creating container > Containers() returns all containers when garden.state is all > Merge pull request #364 from cloudfoundry/with-ginkgo-v2 > go mod tidy && vendor > Bump lager to latest on master > use typeurl/v2 > 🔓 dep > go mod tidy and vendor > go mod tidy > go mod tidy > Merge pull request #361 from cloudfoundry/dependabot/go_modules/github.com/cloudfoundry/gosigar-1.3.9 > Merge pull request #363 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.27.4 > Merge pull request #362 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.7.0 > Merge pull request #345 from cloudfoundry/dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible > Merge pull request #359 from cloudfoundry/unpin-components > Update path to remove unneeded bin dir > Remove runc pin > Add runc to build package > go mod tidy > Merge pull request #355 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.6.19 Submodule src/idmapper a23279655..390987bf5: > Bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1 > Merge pull request #65 from cloudfoundry/unpin-components > Bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0 > Bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4 > Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.8.3 > Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0 > Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 > Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 > Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 > Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0 > Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0 > Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1 > Bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.0 > Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0 > Bump github.com/onsi/ginkgo/v2 from 2.1.5 to 2.1.6 > Bump github.com/onsi/ginkgo/v2 from 2.1.4 to 2.1.5
bump auction auctioneer bbs buildpackapplifecycle bytefmt cacheddownloader cfdot diego-ssh dockerapplifecycle dockerdriver ecrhelper executor fileserver goshims healthcheck inigo localdriver locket operationq rep route-emitter routing-api routing-info systemcerts trace-logger vizzini volman workpool garden grootfs guardian idmapper Submodule src/code.cloudfoundry.org/auction f4db6c51a..20b5e4eb0: > Bump to ginkgo/v2 and lager/v3 (#10) Submodule src/code.cloudfoundry.org/auctioneer 7b69d26e0..6757f6637: > Bump to ginkgo/v2 and lager/v3 (#11) Submodule src/code.cloudfoundry.org/bbs 952b49bde..41bd09f9f: > fix for `go vet` failures (#63) > Bump to lager/v3 (remaining) > Bump sqldb/helpers + test helpers to lager v3 (#61) > Bump to ginkgo/v2 Submodule src/code.cloudfoundry.org/buildpackapplifecycle 9bfd77998..b3c0aa499: > Merge pull request #61 from cloudfoundry/with-ginkgo-v2 > Merge pull request #59 from cloudfoundry/develop Submodule src/code.cloudfoundry.org/cacheddownloader 456a733fa..3de1f8d2e: > Bump to ginkgo/v2 and lager/v3 (#23) Submodule src/code.cloudfoundry.org/cfdot f68fa7f78..9c6e1b442: > Bump to ginkgo/v2 and lager/v3 (#6) Submodule src/code.cloudfoundry.org/diego-ssh 0fc4f3a7d..1003fb588: > Bump to ginkgo/v2 and lager/v3 (#47) Submodule src/code.cloudfoundry.org/dockerapplifecycle 163faedf6..36aa90971: > Bump to ginkgo/v2 (#11) > Regenerate test certificates Submodule src/code.cloudfoundry.org/dockerdriver 16e1fe9ba..76bff1bc5: > Bump to ginkgo/v2 and lager/v3 (#3) > Update PULL_REQUEST_TEMPLATE.md > content change Submodule src/code.cloudfoundry.org/ecrhelper 9a7c7e5a9..3949c0207: > Bump to ginkgo/v2 (#2) Submodule src/code.cloudfoundry.org/executor 1e5a6f15b..208a08c51: > With ginkgo v2 and lager/v3 (#75) > Ensure we release info lock when marshaling fails > Update garden container logging tags > Fix typo in function name > Fetch all containers for cleanup > Executor releases resources only when a container is successfully deleted Submodule src/code.cloudfoundry.org/fileserver 11af6ea87..f3dfda90a: > Bump to ginkgo/v2 && lager/v3 (#7) Submodule src/code.cloudfoundry.org/goshims bb24d2ef7..cf8c6ba6c: > Bump golang.org/x/net from 0.7.0 to 0.8.0 (#24) > Bump golang.org/x/net from 0.0.0-20200301022130-244492dfa37a to 0.7.0 (#23) > Bump github.com/go-sql-driver/mysql from 1.6.0 to 1.7.0 (#22) > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#21) > Revert "Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19)" (#20) > Bump github.com/go-sql-driver/mysql from 1.5.0 to 1.6.0 (#19) > Merge pull request #18 from cloudfoundry/dependabot/add-v2-config-file > Merge pull request #17 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.36.0 > Merge pull request #16 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.35.0 > Merge pull request #15 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.1 > Merge pull request #14 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.34.0 > Merge pull request #13 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.2 > Merge pull request #12 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.33.1 > Merge pull request #11 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.32.0 > Merge pull request #10 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.1 > Merge pull request #9 from cloudfoundry/dependabot/go_modules/master/google.golang.org/grpc-1.31.0 > Merge pull request #8 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.30.0 > go mod vendor > Merge pull request #7 from cloudfoundry/dependabot/go_modules/google.golang.org/grpc-1.29.1 > 🤖 go mod vendor > go get -u all > Add gitignore file > Convert to go modules > Add SetEnv to the command interface Submodule src/code.cloudfoundry.org/healthcheck d7f787b20..7670cbf97: > Bump to ginkgo/v2 (#9) Submodule src/code.cloudfoundry.org/inigo 18bab030e..3c8b1a8f8: > Bump to ginkgo/v2 & lager/v3 (#25) Submodule src/code.cloudfoundry.org/localdriver 1b0a47b1c..0668dcc60: > Bump to ginkgo/v2 & lager/v3 (#2) Submodule src/code.cloudfoundry.org/locket 76a930295..5e8522d97: > {fake_runner,fake_runner_v2} to be used with (#14) > Add BeforeSuite in the right place > Fix govet errors > Bump to lager v3 > WIP - upgrading to ginkgo v2+ ginkgomon_v2 Submodule src/code.cloudfoundry.org/operationq da3eb228f..4522d0860: > Bump to ginkgo/v2 (#2) > Fix the test for max capacity > Ginkgo v2: don't use Done channels > Update PULL_REQUEST_TEMPLATE.md > content change Submodule src/code.cloudfoundry.org/rep be8beeb46..f627e21dd: > Bump to ginkgo/v2 && lager/v3 (#39) Submodule src/code.cloudfoundry.org/route-emitter c907cd8f6..da039b0c1: > Bump to ginkgo/v2 && lager/v3 (#21) Submodule src/code.cloudfoundry.org/routing-api ff096da8d..2bf566855: > Fix ginkgo deprecations with Done channels > Fix ginkgo v2 flag deprecation notices > Bump to lager v3 > Convert to ginkgo v2 + inline the archived trace package > Convert to ginkgo v2 + inline the archived trace package > ignore .test files in the repo > Bump to ginkgo/v2 > Bump to ginkgo/v2 - WIP > Allow uaaclient callers to optionally pass in a protocol via (#30) Submodule src/code.cloudfoundry.org/routing-info 7d023ecb0..c6998d604: > Bump to ginkgo/v2 Submodule src/code.cloudfoundry.org/systemcerts 95ea366d9..5244fcb1b: > refactor: rm use of internal/testenv Submodule src/code.cloudfoundry.org/vizzini a59096109...6474f903a: > fix `go vet` failures > Bump to ginkgo/v2 && lager/v3 < Fix one more test using metric tags Submodule src/code.cloudfoundry.org/volman 4129b3172..76091d503: > Bump to ginkgo/v2 && lager/v3 (#5) Submodule src/code.cloudfoundry.org/workpool e8b9128ee..2e26d5d93: > Bump to ginkgo/v2 (#2) > Update PULL_REQUEST_TEMPLATE.md > content change Submodule src/garden d57de807d..8534099e1: > Migrate to lager v3 > Migrate to ginkgo/v2 > Bump lager to latest on master > Revert "bump ginkgo to v2 and lager to v3" > Merge pull request #107 from xtremerui/bump-ginkgo-lager > Bump golang.org/x/net from 0.0.0-20210428140749-89ef3d95e781 to 0.7.0 > Merge pull request #105 from cloudfoundry/unpin-components > Merge pull request #103 from ebroberson/ginkgov2-done-channels Submodule src/grootfs ba02da43d..df476b3ba: > Swtch to channels from pool > Return to pool xfs mounts that don't cause test pollution > Generate 10 mount points for all quota tests > Use unique mount directory for each test > Merge pull request #197 from cloudfoundry/with-ginkgo-v2 > go mod tidy && vendor > Bump lager to latest on master > 🔒 dep > Merge pull request #196 from cloudfoundry/unpin-components > Bump golang.org/x/sys from 0.5.0 to 0.6.0 > go mod tidy > Merge remote-tracking branch 'local/dependabot/go_modules/code.cloudfoundry.org/lager-2.0.0incompatible' into main > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/containers/image/v5-5.24.2' into main > Merge remote-tracking branch 'local/dependabot/go_modules/github.com/docker/docker-23.0.1incompatible' into main > Merge remote-tracking branch 'local/dependabot/go_modules/golang.org/x/sys-0.5.0' into main > Bump github.com/opencontainers/runtime-spec > Merge pull request #191 from cloudfoundry/out-of-disk-error-with-jammy Submodule src/guardian 913b899bc..86f0a7d78: > Set container properties before creating container > Containers() returns all containers when garden.state is all > Merge pull request #364 from cloudfoundry/with-ginkgo-v2 > go mod tidy && vendor > Bump lager to latest on master > use typeurl/v2 > 🔓 dep > go mod tidy and vendor > go mod tidy > go mod tidy > Merge pull request #361 from cloudfoundry/dependabot/go_modules/github.com/cloudfoundry/gosigar-1.3.9 > Merge pull request #363 from cloudfoundry/dependabot/go_modules/github.com/onsi/gomega-1.27.4 > Merge pull request #362 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.7.0 > Merge pull request #345 from cloudfoundry/dependabot/go_modules/github.com/emicklei/go-restful-2.16.0incompatible > Merge pull request #359 from cloudfoundry/unpin-components > Update path to remove unneeded bin dir > Remove runc pin > Add runc to build package > go mod tidy > Merge pull request #355 from cloudfoundry/dependabot/go_modules/github.com/containerd/containerd-1.6.19 Submodule src/idmapper a23279655..390987bf5: > Bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1 > Merge pull request #65 from cloudfoundry/unpin-components > Bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0 > Bump github.com/onsi/ginkgo/v2 from 2.8.3 to 2.8.4 > Bump github.com/onsi/ginkgo/v2 from 2.7.0 to 2.8.3 > Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0 > Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 > Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 > Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 > Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0 > Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0 > Bump github.com/onsi/ginkgo/v2 from 2.3.0 to 2.3.1 > Bump github.com/onsi/ginkgo/v2 from 2.2.0 to 2.3.0 > Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0 > Bump github.com/onsi/ginkgo/v2 from 2.1.5 to 2.1.6 > Bump github.com/onsi/ginkgo/v2 from 2.1.4 to 2.1.5
https://github.com/cloudfoundry/executor/blob/0c06103dc4fa8cc5fc98c4dc7302752d6351f9b2/depot/steps/run_step.go#L18
Would allow deployers the ability to control the time between sigterm and sigkill. Some customers workloads are more sensitive to restarts and although allowing the customer to set this value on a per application basis might be the optimal solution to this problem, allowing the deployer to customize it for the platform would be a good step in the direction of better understanding need and potential problems around different terminate timeout values.
Thanks.
The text was updated successfully, but these errors were encountered: