Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows app lifecycle to support windows stacks [#90637182] #28

Closed
wants to merge 1 commit into from
Closed

Add windows app lifecycle to support windows stacks [#90637182] #28

wants to merge 1 commit into from

Conversation

jvshahid
Copy link
Contributor

NB. To use windows stack, it is also neccessary to use
templates/enable_diego_windows_in_cc.yml in CF manifest generation. This
will specify lucid64 and windows stacks.

@cfdreddbot
Copy link

Hey jvshahid!

Thanks for submitting this pull request!

All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/90810706.

@dgoddard dgoddard force-pushed the greenhouse branch 2 times, most recently from fbcdca7 to 61ec48f Compare March 24, 2015 20:57
Add windows app lifecycle to support windows stacks [#90637182]
435b105 
NB. To use windows stack, it is also neccessary to use
templates/enable_diego_windows_in_cc.yml in CF manifest generation. This
will specify lucid64 and windows stacks.
@emalm
Copy link
Member

emalm commented Mar 26, 2015

Hey, @jvshahid,

How does the windows app lifecycle tarball actually work with diego? Stager and Nsync are building task/LRP recipes that refer to executables called builder, launcher, and healthcheck, but we see they're named Builder.exe, Launcher.exe, Healthcheck.exe in the Windows app lifecycle tarball. We're gonna merge in these changes, but just curious what's responsible for making it work?

Thanks,
Eric && @Amit-PivotalLabs

@jvshahid
Copy link
Contributor Author

(@mavenraven and @dgoddard can correct me if i'm wrong) windows is case insensitive and you don't need to specify the extension (.exe in this case) of the executable you're running. The docs for Process.Start backs up my optional extension theory. That's why running healthcheck will end up running Healthcheck.exe, etc.

@mavenraven
Copy link
Contributor

@ematpl @jvshahid that's correct: http://superuser.com/questions/619921/how-to-run-an-executable-file-without-exe-extension-using-cmd-script

@emalm
Copy link
Member

emalm commented Mar 27, 2015

Okey dokey! The PR commit is now on develop as 56ddff9, and will make it to master the next time our pipeline cuts a final release. Closing this out as merged.

@emalm emalm closed this Mar 27, 2015
@dgoddard
Copy link
Contributor

Thanks!

fraenkel pushed a commit that referenced this pull request Apr 15, 2015
@atulkc
bump executor garden garden-linux
372cd42 
[delivers #92484984]

Submodule src/github.com/cloudfoundry-incubator/executor 3232541..b9aed80:
  > Change some logging to Info from Debug [#92484984]
Submodule src/github.com/cloudfoundry-incubator/garden c25ae1e..dd6b2d5:
  > Remove protobuf dependencies
  > +/- 50ms - acceptable tolerance for gracetime testing
  > bump the acceptable tolerance for gracetime testing
  > Improve error handling of iostreams.
  > Remove dead code from connection
Submodule src/github.com/cloudfoundry-incubator/garden-linux 6349be3..a64ad73:
  > Tidy up pull request
  > Merge pull request #28 from shashidharatd/hw-issue-1
  > Replace `Ω(...).Should(...)` with `Expect(...).To(...)`
  > Create a container from an empty rootfs
  > Bump to latest Gomega with File matchers
  > Refactor flags_test
  > Merge pull request #33 from shashidharatd/hwcf-issue-2
  > Fix local ginkgo runs
  > update packer README: mkdir $TMPDIR before running packer
  > Absorb output to avoid file descriptors lingering excessively.
  > $@ gave rise to this:
  > Remove extraneous text in diagram.
  > Add process flow diagram to developer docs.
  > Concourse jobs now run with garden-ci-ubuntu docker image.
  > Document how to run tests using Docker
  > Developers should use go1.4
  > Build images with packer
  > Use garden without protobuf dependency
  > Use latest Garden with enhanced iostream error handling
  > Revert "Remove .drone.yml as it doesn't seem to be in use."
  > Remove .drone.yml as it doesn't seem to be in use.
  > remove debug log from test
  > Retry reading the pid file if there is no data present
  > Merge pull request #26 from cloudfoundry-incubator/mute-garden
  > Add timeout flag to specify how long to wait for the first connection.
  > Replace hook-child-after-pivot.sh with Go code.
  > Reduce number of iterations in integration test.
  > Replace duplicated code with reused functions.
  > Remove unecessary integration test.
  > Increase the slow spec threshold to 15s
  > Remove unneeded integration tests

Signed-off-by: Matt Royal <mroyal@pivotal.io>
caod123 added a commit that referenced this pull request Dec 15, 2016
@caod123
bump diego-ssh
690d091 
[finishes #135979115]

Submodule src/code.cloudfoundry.org/diego-ssh 30305a90..fcd09835:
  > Merge pull request #28 from mhoran/no-exec-windows
@emalm emalm deleted the greenhouse branch December 11, 2017 10:50
crhino pushed a commit that referenced this pull request Jan 11, 2018
@cf-buildpacks-eng
bump buildpackapplifecycle
91c7286 
[finishes #src/code.cloudfoundry.org/buildpackapplifecycle]

Submodule src/code.cloudfoundry.org/buildpackapplifecycle ef6149f..3746a1e:
  > Merge pull request #28 from greenhouse-org/windows-capture-output
nimakaviani pushed a commit that referenced this pull request Aug 2, 2018
@jvshahid @nimakaviani
bump executor ifrit
f1eee73 
[finishes #156440269](https://www.pivotaltracker.com/story/show/156440269)

Submodule src/code.cloudfoundry.org/executor d70b0baa..2aa9d878:
  > fixup graceful traffic refusal between gorouter and envoy
Submodule src/github.com/tedsuo/ifrit d787ed1df..bea94bb47:
  > Merge pull request #29 from nimakaviani/master
  > Merge pull request #28 from jvshahid/more-meaningful-error
  > Merge pull request #27 from rameshthoomu/master
  > Merge pull request #26 from sykesm/expose-err

Signed-off-by: Nima Kaviani <nkavian@us.ibm.com>
winkingturtle-vmw added a commit that referenced this pull request Nov 14, 2023
@winkingturtle-vmw
bump auction auctioneer bbs buildpackapplifecycle cacheddownloader di…
3d0da82 
…ego-ssh executor inigo locket rep route-emitter

Submodule src/code.cloudfoundry.org/auction cb67f2df8...a0b5f6cb4:
  > Add test.bash (#17)
  < Add test.bash
Submodule src/code.cloudfoundry.org/auctioneer 53ba4c3b4...4c948374c:
  > With oss ci export (#16)
  < Regenerate expiring certs
  < use relative path instead of direnv
Submodule src/code.cloudfoundry.org/bbs af5179eaf...709d9ebc2:
  > With oss ci export (#75)
  > Add availability zone to actual LRPs (#74)
  < Regenerate expiring certs
  < set -e to exit when something fails
  < Fix path
  < Address pathing issue with gogo protobuf generator
  < Fix go fmt
  < Remove Focus that was added for local run only
  < fix test to allow for one event to
  < SQLFLAVOR_USER->DB_USER and PASSWORD
  < SQLFLAVOR_USER->DB_USER and PASSWORD
  < SQL_FLAVOR->DB env
  < use relative path instead of direnv
  < go fmt
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 2c73ee370..66d4e9349:
  > Merge pull request #64 from cloudfoundry/with-oss-ci-export
Submodule src/code.cloudfoundry.org/cacheddownloader e92422e07...bb834a3fe:
  > Regenerate expiring certs (#27)
  < Regenerate expiring certs
Submodule src/code.cloudfoundry.org/diego-ssh 1126e2462...0db8c3650:
  > With oss ci export (#51)
  < Ensure GinkgoRecover in go routine
  < Create a new err
  < Fix a potential race condition
  < Add bin/test.bash
  < Check if DLL is found instead of dir
  < ensure ZipArchiveMode is loaded
  < Add bin/test.ps1 for WINPTY_DLL_DIR
  < remove unneeded vars
  < Grab a different port than other tests
  < use relative path instead of direnv
Submodule src/code.cloudfoundry.org/executor 0c69be068...aa6d9b164:
  > With oss ci export (#88)
  < Regenerate expiring certs
  < Regenerate expiring certs
  < Address channel buffer issue test flake
  < Fix go fmt
  < Wait long enough for log to appear
Submodule src/code.cloudfoundry.org/inigo 31ce39424...04c069a3b:
  > With oss ci export (#28)
  < Unlock mutex when it's returning early
  < ioutil->os
  < Skip deleting auctioneer-config for windows
  < Use ci's filesystem-helpers.bash
  < rsync with retry, because it seems flaky
  < Wait for mysqld to be stopped
  < On windows, don't wait for tmpDir to be deleted
  < Add progres report back
  < Not sure why we need to setup
  < Wait longer after being Killed
  < Revert "Send SIGINT instead of SIGKILL"
  < Send SIGINT instead of SIGKILL
  < Use ci's helper instead
  < Wait longer for auctioneer to have been stopped
  < Add a debug for envoy.exe path
  < Print output to stdout
  < Add logs.txt output to show progress
  < fix extra space
  < Swap the order for Out-File to be after Invoke-Expression
  < Add Encoding and Width
  < use correct folder name
  < Use a timestamp for inigo-logs
  < unfocus tests
  < Set PROXY_BINARY
  < Focus the failing test
  < Remove debug logs
  < Add missing -F
  < Invoke ginkgo
  < Use correct env variable
  < winc-> winc-network
  < use correct env variables
  < Remove unneeded function
  < fix tmp dir
  < Keep all vendored
  < Add test.ps1 for windows version
  < mkdir logs dir
  < Use a dir for logs
  < Use binaries from GARDEN_BINPATH
  < Add GROOTFS_BINPATH
  < Revert "GROOTFS_BINPATH->GROOTFS_BINARY"
  < GROOTFS_BINPATH->GROOTFS_BINARY
  < use builds from CI instead of building in the test task
  < Use updated docker image for dependencies
  < Remove packages that might not be needed
  < Max connection to 2000 for mysql
  < Use PROXY_BINARY from build-binaries task
  < Fix go vet issues
  < Use garden-runc-release's tar for rootfs
  < build rootfs instead of providing an OCI built one
  < Add more packages
  < Add uidmap
  < Add tag for gdn
  < symlink tar
  < resolve pg_cof value
  < user NATS_SERVER_BINARY
  < relative resolve pg_conf
  < Install required dependencies
  < Use env variable for garden-runc
  < Use correct env
  < {sudo,}
  < Add dnsmasq as a depedency
  < Add bin/test.bash
  < User DB_USER and DB_PASSWORD instead
  < Use correct path for finding fixtures
Submodule src/code.cloudfoundry.org/locket 7a13b7b4d...23339499a:
  > With oss ci export (#16)
  < Regenerate expiring certs
  < set -e to exit when something fails
  < Fix path
  < Address issue with gogo protobuf generator
  < SQLFLAVOR_USER->DB_USER and PASSWORD
Submodule src/code.cloudfoundry.org/rep b26698303...eedf2cd88:
  > With oss ci export (#49)
  > Send AZ in StartActualLRP/EvacuateRunningActualLRP requests to BBS (#48)
  < change db_name to a unique name
  < Update port ranges to use more unique number to avoid port collisions under Windows
  < use relative path instead of direnv
Submodule src/code.cloudfoundry.org/route-emitter 828ee627e...96aae07f6:
  > With oss ci export (#30)
  > Add AZ to registry message (#29)
  < Modify Main test suite to use more unique database name
  < Use NATS_SERVER_BINARY instead
  < use relative path instead of direnv
@winkingturtle-vmw winkingturtle-vmw mentioned this pull request Nov 14, 2023
Merged
3 tasks
MarcPaquette pushed a commit that referenced this pull request Nov 14, 2023
@winkingturtle-vmw
bump auction auctioneer bbs buildpackapplifecycle cacheddownloader di…
12462b7 
…ego-ssh executor inigo locket rep route-emitter (#859)

Submodule src/code.cloudfoundry.org/auction cb67f2df8...a0b5f6cb4:
  > Add test.bash (#17)
  < Add test.bash
Submodule src/code.cloudfoundry.org/auctioneer 53ba4c3b4...4c948374c:
  > With oss ci export (#16)
  < Regenerate expiring certs
  < use relative path instead of direnv
Submodule src/code.cloudfoundry.org/bbs af5179eaf...709d9ebc2:
  > With oss ci export (#75)
  > Add availability zone to actual LRPs (#74)
  < Regenerate expiring certs
  < set -e to exit when something fails
  < Fix path
  < Address pathing issue with gogo protobuf generator
  < Fix go fmt
  < Remove Focus that was added for local run only
  < fix test to allow for one event to
  < SQLFLAVOR_USER->DB_USER and PASSWORD
  < SQLFLAVOR_USER->DB_USER and PASSWORD
  < SQL_FLAVOR->DB env
  < use relative path instead of direnv
  < go fmt
Submodule src/code.cloudfoundry.org/buildpackapplifecycle 2c73ee370..66d4e9349:
  > Merge pull request #64 from cloudfoundry/with-oss-ci-export
Submodule src/code.cloudfoundry.org/cacheddownloader e92422e07...bb834a3fe:
  > Regenerate expiring certs (#27)
  < Regenerate expiring certs
Submodule src/code.cloudfoundry.org/diego-ssh 1126e2462...0db8c3650:
  > With oss ci export (#51)
  < Ensure GinkgoRecover in go routine
  < Create a new err
  < Fix a potential race condition
  < Add bin/test.bash
  < Check if DLL is found instead of dir
  < ensure ZipArchiveMode is loaded
  < Add bin/test.ps1 for WINPTY_DLL_DIR
  < remove unneeded vars
  < Grab a different port than other tests
  < use relative path instead of direnv
Submodule src/code.cloudfoundry.org/executor 0c69be068...aa6d9b164:
  > With oss ci export (#88)
  < Regenerate expiring certs
  < Regenerate expiring certs
  < Address channel buffer issue test flake
  < Fix go fmt
  < Wait long enough for log to appear
Submodule src/code.cloudfoundry.org/inigo 31ce39424...04c069a3b:
  > With oss ci export (#28)
  < Unlock mutex when it's returning early
  < ioutil->os
  < Skip deleting auctioneer-config for windows
  < Use ci's filesystem-helpers.bash
  < rsync with retry, because it seems flaky
  < Wait for mysqld to be stopped
  < On windows, don't wait for tmpDir to be deleted
  < Add progres report back
  < Not sure why we need to setup
  < Wait longer after being Killed
  < Revert "Send SIGINT instead of SIGKILL"
  < Send SIGINT instead of SIGKILL
  < Use ci's helper instead
  < Wait longer for auctioneer to have been stopped
  < Add a debug for envoy.exe path
  < Print output to stdout
  < Add logs.txt output to show progress
  < fix extra space
  < Swap the order for Out-File to be after Invoke-Expression
  < Add Encoding and Width
  < use correct folder name
  < Use a timestamp for inigo-logs
  < unfocus tests
  < Set PROXY_BINARY
  < Focus the failing test
  < Remove debug logs
  < Add missing -F
  < Invoke ginkgo
  < Use correct env variable
  < winc-> winc-network
  < use correct env variables
  < Remove unneeded function
  < fix tmp dir
  < Keep all vendored
  < Add test.ps1 for windows version
  < mkdir logs dir
  < Use a dir for logs
  < Use binaries from GARDEN_BINPATH
  < Add GROOTFS_BINPATH
  < Revert "GROOTFS_BINPATH->GROOTFS_BINARY"
  < GROOTFS_BINPATH->GROOTFS_BINARY
  < use builds from CI instead of building in the test task
  < Use updated docker image for dependencies
  < Remove packages that might not be needed
  < Max connection to 2000 for mysql
  < Use PROXY_BINARY from build-binaries task
  < Fix go vet issues
  < Use garden-runc-release's tar for rootfs
  < build rootfs instead of providing an OCI built one
  < Add more packages
  < Add uidmap
  < Add tag for gdn
  < symlink tar
  < resolve pg_cof value
  < user NATS_SERVER_BINARY
  < relative resolve pg_conf
  < Install required dependencies
  < Use env variable for garden-runc
  < Use correct env
  < {sudo,}
  < Add dnsmasq as a depedency
  < Add bin/test.bash
  < User DB_USER and DB_PASSWORD instead
  < Use correct path for finding fixtures
Submodule src/code.cloudfoundry.org/locket 7a13b7b4d...23339499a:
  > With oss ci export (#16)
  < Regenerate expiring certs
  < set -e to exit when something fails
  < Fix path
  < Address issue with gogo protobuf generator
  < SQLFLAVOR_USER->DB_USER and PASSWORD
Submodule src/code.cloudfoundry.org/rep b26698303...eedf2cd88:
  > With oss ci export (#49)
  > Send AZ in StartActualLRP/EvacuateRunningActualLRP requests to BBS (#48)
  < change db_name to a unique name
  < Update port ranges to use more unique number to avoid port collisions under Windows
  < use relative path instead of direnv
Submodule src/code.cloudfoundry.org/route-emitter 828ee627e...96aae07f6:
  > With oss ci export (#30)
  > Add AZ to registry message (#29)
  < Modify Main test suite to use more unique database name
  < Use NATS_SERVER_BINARY instead
  < use relative path instead of direnv
tas-runtime-bot pushed a commit that referenced this pull request Dec 27, 2023
bump bbs cacheddownloader credhub-cli rep garden grootfs guardian idm…
e2a5c35 
…apper

Submodule src/code.cloudfoundry.org/bbs 1b287db66..b45866dbb:
  > Revert "Start server with Unavailable handler until lock is ready"
  > Add metric tags to task definition (#77)
Submodule src/code.cloudfoundry.org/cacheddownloader bb834a3fe..665f7b048:
  > Convert cacheddownloader to a go module (#28)
Submodule src/code.cloudfoundry.org/credhub-cli 4bd1f774f..156833ebf:
  > Bump go modules
Submodule src/code.cloudfoundry.org/rep eedf2cd88..c55fff800:
  > Adds metric tags to task logs (#50)
Submodule src/garden 7c85e0f7a..f6a5ba9c5:
  > Update go.mod dependencies
Submodule src/grootfs 2d7376525..55af5dac6:
  > Update go.mod dependencies
Submodule src/guardian fbef8d9bb..e49d38ea2:
  > Update go.mod dependencies
  > Merge pull request #426 from cloudfoundry/fix-unit-and-integration-tests/builds/16.1
Submodule src/idmapper d89a35477..ec81d4362:
  > Update go.mod dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jvshahid @cfdreddbot @cf-gitbot @emalm @mavenraven @dgoddard