Bump windows app lifecycle #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#88945102] Signed-off-by: Ben_Moss <bmoss@pivotal.io>
|
Hey jvshahid! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you've already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this. You can view the current status of your issue at: https://www.pivotaltracker.com/story/show/96117404. |
jvshahid
pushed a commit
that referenced
this pull request
Oct 19, 2017
[finishes #150821436] closes #353 Submodule src/code.cloudfoundry.org/dockerapplifecycle 9807a9c0..090d29da: > Replace the manifest with a more recent manifest Submodule src/github.com/docker/distribution ec87e9b69...916276044: > Merge pull request #1271 from aaronlehmann/remove-tarsum > Merge pull request #1264 from aaronlehmann/hash-errors > Merge pull request #1258 from thaJeztah/fix-docs-headers > Merge pull request #1267 from gabriellhrn/typo > Merge pull request #1245 from carsonoid/carsonoid-nginx-doc-patch-2 > Merge pull request #1253 from RichardScothern/go-1.5.2 > Merge pull request #1250 from RichardScothern/AUTHORS > Merge pull request #1187 from stevvooe/check-storage-drivers-list-path-not-found > Merge pull request #1246 from stevvooe/decrease-driver-testsuite-allocations > Merge pull request #1237 from thaJeztah/update-maintainers > Merge pull request #1238 from noxiouz/fix_comment > Merge pull request #1241 from pdevine/catalog-speedup > Merge pull request #1243 from RichardScothern/client-header-message > Merge pull request #1157 from lebauce/swift-bulk-delete-fixes > Merge pull request #1239 from stevvooe/refactor-reference-grammar > Merge pull request #1234 from SvenDowideit/linkchecker-fixes > Merge pull request #1233 from kendru/patch-1 > Merge pull request #1231 from tonistiigi/digest-length-check > Merge pull request #1211 from tt/remove-name-verification > Merge pull request #1232 from pdevine/catalog-clarification > Merge pull request #1227 from stevvooe/walk-sorted > Merge pull request #1226 from aaronlehmann/avoid-stat-roundtrips > Merge pull request #1225 from SvenDowideit/DOCS-227 > Merge pull request #1213 from SvenDowideit/move-to-docs-base-latest > Merge pull request #1208 from farmerworking/fix-oss-doc-error > Merge pull request #1204 from MHBauer/gh1197 > Merge pull request #1207 from Djelibeybi/master > Merge pull request #1198 from jonboulle/master > Merge pull request #1193 from SvenDowideit/docs-validation-changes > Merge pull request #1166 from treed/master > Merge pull request #910 from RichardScothern/go-1.5 > Merge pull request #1125 from rustyconover/fix-url-path-escaping > Merge pull request #1141 from lebauce/swift-no-missing-segment > Merge pull request #1172 from aaronlehmann/swift-empty-delete-request > Merge pull request #1156 from RichardScothern/manifest-verification > Merge pull request #1161 from stevvooe/add-status-badges > Merge pull request #1150 from RichardScothern/carry-1070 > Merge pull request #1114 from lebauce/swift-temp-url > Merge pull request #1152 from RichardScothern/credit2 > Merge pull request #1151 from RichardScothern/credit > Merge pull request #1149 from stevvooe/close-filereader > Merge pull request #1148 from aaronlehmann/withname-check-length > Merge pull request #1122 from RichardScothern/scheduler-coalesce > Merge pull request #1139 from aaronlehmann/reference-withtag-fix > Merge pull request #756 from aibaars/storage-gcs > Merge pull request #1096 from aaronlehmann/simplify-proxy-scheduler > Merge pull request #1136 from RichardScothern/update-roadmap > Merge pull request #1047 from mattmoor/expires_in_proposal > Merge pull request #1099 from RichardScothern/go-version > Merge pull request #1121 from thaJeztah/fix-doc-emoji > Merge pull request #1095 from mrwacky42/api-version-annotated > Merge pull request #1118 from SvenDowideit/stop-linking-when-rendering-to-html > Merge pull request #1098 from denverdino/master > Merge pull request #1115 from tianon/fix-auth-servehttp-comment > Merge pull request #1111 from aaronlehmann/golint-comments > Merge pull request #1110 from RichardScothern/env-var-clarification > Merge pull request #1006 from RichardScothern/proxy-serialize > Merge pull request #1103 from moxiegirl/hugo-15-retooling > Merge pull request #827 from aaronlehmann/read-only-mode-2 > Merge pull request #1053 from mrwacky42/patch-1 > Merge pull request #1094 from aaronlehmann/correct-payload-serialization-order > Merge pull request #1093 from aaronlehmann/reference-improvements > Merge pull request #1035 from aaronlehmann/host-parameter-alternate > Merge pull request #1033 from jlhawn/api_spec_update_auth_errors > Merge pull request #963 from dmcgowan/reference-update > Merge pull request #1083 from BrianBland/fixSwiftDocs > Merge pull request #1079 from mattmoor/allow-hostname-parts > Merge pull request #1072 from compnski/patch-1 > Merge pull request #1076 from harche/patch-2 > Merge pull request #1048 from docker/docs-secure-default > Merge pull request #950 from jackpgriffin/master > Merge pull request #1005 from xiekeyang/spec > Merge pull request #988 from tt/fix-incorrect-default > Merge pull request #1045 from tt/remove-duplicate-dependency-definition > Merge pull request #1036 from dmcgowan/digest-set-update > Merge pull request #1024 from aaronlehmann/avoid-testing-import > Merge pull request #1042 from tt/upgrade-amazon-library > Merge pull request #1001 from RichardScothern/fix-atrocity > Merge pull request #991 from mattmoor/expires_in_proposal > Merge pull request #999 from nakedible-p/patch-1 > Merge pull request #1014 from shyr/patch-3 > Merge pull request #997 from xiekeyang/typo > Merge pull request #981 from LouisKottmann/master > Merge pull request #973 from jlhawn/update_token_spec > Merge pull request #974 from stevvooe/context-cleanup > Merge pull request #977 from aaronlehmann/use-distribution-context > Merge pull request #909 from aaronlehmann/importable-registry > Merge pull request #888 from aaronlehmann/config-env-vars > Merge pull request #964 from aaronlehmann/pin-dind-dep > Merge pull request #946 from humble00/master > Merge pull request #949 from docker/amylindburg-patch-1 > Merge pull request #941 from liubin/master > Merge pull request #931 from dmp42/5.all-ur-proxy-are-belong-to-us < Correctly sanitize location url preserving parameters > Merge pull request #934 from stevvooe/sanitize-url-correctly > Merge pull request #929 from RichardScothern/docs > Merge pull request #932 from avinson/master > Merge pull request #918 from aaronlehmann/json-spec > Merge pull request #897 from dmp42/5.all-ur-proxy-are-belong-to-us > Merge pull request #912 from stevvooe/manifest-refactoring-schema1 > Merge pull request #907 from stevvooe/digest-tool > Merge pull request #876 from dmcgowan/integration-test-cleanup > Merge pull request #901 from aaronlehmann/configurable-health-checks > Merge pull request #893 from aaronlehmann/functional-opts > Merge pull request #896 from aaronlehmann/closenotifier-warnings > Merge pull request #894 from aaronlehmann/fix-tests > Merge pull request #874 from stevvooe/load-balancer-endpoint > Merge pull request #846 from aaronlehmann/http-header-configuration > Merge pull request #883 from tg123/master > Merge pull request #889 from stevvooe/remove-pathmapper > Merge pull request #881 from samsong8610/update-example-config-to-use-blobdescriptor > Merge pull request #869 from mssola/delete-documentation > Merge pull request #864 from stevvooe/use-correct-manifest-link > Merge pull request #865 from dmp42/4.docs-2.1 > Merge pull request #862 from stevvooe/dont-comment-on-closed-issues > Merge pull request #856 from dmp42/4.docs-2.1 > Merge pull request #847 from aaronlehmann/harmonize-config-paths > Merge pull request #848 from RichardScothern/error-type > Merge pull request #853 from dmp42/4.docs-2.1 > Merge pull request #852 from ahmetalpbalkan/docs/typo > Merge pull request #831 from stevvooe/add-driver-health-check > Merge pull request #851 from ahmetalpbalkan/docs/redirect > Merge pull request #821 from aaronlehmann/docker-integration-fixes-3 > Merge pull request #845 from gierschv/add-rados-root-omap > Merge pull request #837 from dmp42/4.docs-2.1 > Merge pull request #839 from n1tr0g/master > Merge pull request #836 from stevvooe/fix-mailmap-scothern > Merge pull request #835 from stevvooe/update-authors > Merge pull request #833 from stevvooe/remove-dist-tool > Merge pull request #834 from stevvooe/rev-default-version > Merge pull request #830 from aaronlehmann/no-closenotifier-panic > Merge pull request #818 from dmp42/3.fix-build-docs > Merge pull request #829 from aaronlehmann/aliyun-oss-doc-styling > Merge pull request #779 from RichardScothern/pull-through-cache > Merge pull request #816 from mbentley/add-migrator > Merge pull request #805 from RichardScothern/811 > Merge pull request #817 from aaronlehmann/docker-integration-fixes-2 > Merge pull request #514 from denverdino/master > Merge pull request #815 from aaronlehmann/docker-integration-fixes > Merge pull request #814 from aaronlehmann/test-response-writer > Merge pull request #783 from aaronlehmann/multiple-version-integration-testing > Merge pull request #763 from aaronlehmann/close-notifier > Merge pull request #803 from duglin/FixBuild > Merge pull request #811 from aaronlehmann/fix-vet > Merge pull request #812 from stevvooe/update-s3-dependency > Merge pull request #801 from alexwlchan/master Submodule src/github.com/docker/libtrust fa567046d..aabc10ec2: > Merge pull request #56 from thaJeztah/add-deprecation-warning > Merge pull request #54 from stweil/master > Merge pull request #52 from vbatts/vbatts-test_base64url > Merge pull request #49 from stevvooe/signature-assembly Signed-off-by: John Shahid <jvshahid@gmail.com>
tas-runtime-bot
added a commit
that referenced
this pull request
Jun 14, 2023
…credhub-cli diego-ssh dockerapplifecycle ecrhelper executor fileserver healthcheck inigo localdriver locket operationq rep route-emitter routing-api routing-info systemcerts vizzini volman workpool garden grootfs guardian idmapper Submodule src/code.cloudfoundry.org/auction 46a89db7a..4c03ffcd7: > Add CODEOWNERS file in preparation for branch protection rules (#16) Submodule src/code.cloudfoundry.org/auctioneer be803dc1e..ec7efd6f7: > Add CODEOWNERS file in preparation for branch protection rules (#14) Submodule src/code.cloudfoundry.org/buildpackapplifecycle 717bad3b1..cb243e1d2: > Merge pull request #48 from Infra-Red/staging-error > Merge pull request #62 from geofffranks/main Submodule src/code.cloudfoundry.org/cacheddownloader a005bb235..2caa6ca34: > Add CODEOWNERS file in preparation for branch protection rules (#25) Submodule src/code.cloudfoundry.org/cfdot ef69fb66b..4d194a115: > Add CODEOWNERS file in preparation for branch protection rules (#8) Submodule src/code.cloudfoundry.org/credhub-cli a97b4319d..aa8fc4e79: > Bump go modules Submodule src/code.cloudfoundry.org/diego-ssh 1bdd96ca0..7461829a9: > Add CODEOWNERS file in preparation for branch protection rules (#49) Submodule src/code.cloudfoundry.org/dockerapplifecycle 0e49eedc7..93dcb397b: > Add CODEOWNERS file in preparation for branch protection rules (#12) Submodule src/code.cloudfoundry.org/ecrhelper 3949c0207..56a9cdc53: > Add CODEOWNERS file in preparation for branch protection rules (#3) Submodule src/code.cloudfoundry.org/executor d6dd1132b..2c29c7e2f: > Add CODEOWNERS file in preparation for branch protection rules (#81) Submodule src/code.cloudfoundry.org/fileserver f3dfda90a..ddeb9bd6d: > Add CODEOWNERS file in preparation for branch protection rules (#8) Submodule src/code.cloudfoundry.org/healthcheck ba40fd720..6587beaf1: > Add CODEOWNERS file in preparation for branch protection rules (#10) Submodule src/code.cloudfoundry.org/inigo 8e5bf0cc7..b300679e6: > Add CODEOWNERS file in preparation for branch protection rules (#27) Submodule src/code.cloudfoundry.org/localdriver bfbf40217..6d5a2bf56: > Add CODEOWNERS file in preparation for branch protection rules (#3) Submodule src/code.cloudfoundry.org/locket 6cd541649..08e003863: > Add CODEOWNERS file in preparation for branch protection rules (#15) Submodule src/code.cloudfoundry.org/operationq 4522d0860..b625ea3c1: > Add CODEOWNERS file in preparation for branch protection rules (#3) Submodule src/code.cloudfoundry.org/rep 8550a6340..192ca3a5a: > Add CODEOWNERS file in preparation for branch protection rules (#43) Submodule src/code.cloudfoundry.org/route-emitter b5abb628c..a17e814f0: > Add CODEOWNERS file in preparation for branch protection rules (#25) Submodule src/code.cloudfoundry.org/routing-api 9592985dc..b9e9e0b90: > Add CODEOWNERS file in preparation for branch protection rules Submodule src/code.cloudfoundry.org/routing-info c6998d604..079a27345: > Add CODEOWNERS file in preparation for branch protection rules Submodule src/code.cloudfoundry.org/systemcerts 221d6f2ae..10f68b45f: > Add CODEOWNERS file in preparation for branch protection rules (#2) Submodule src/code.cloudfoundry.org/vizzini 906e23011..5a2ef7822: > Add CODEOWNERS file in preparation for branch protection rules (#6) Submodule src/code.cloudfoundry.org/volman 76091d503..b60663cd4: > Add CODEOWNERS file in preparation for branch protection rules (#6) Submodule src/code.cloudfoundry.org/workpool 2e26d5d93..b93da105e: > Add CODEOWNERS file in preparation for branch protection rules (#3) Submodule src/garden ac53c57dc..2d96d2498: > Bump lager to v3.0.2 > Update go.mod dependencies Submodule src/grootfs 9ea0d4bb9..f8dceb408: > Bump lager to v3.0.2 > Update go.mod dependencies > Merge pull request #217 from geofffranks/main Submodule src/guardian fac28108a..809884ce5: > Bump lager to v3.0.2 > Update go.mod dependencies > Merge pull request #402 from geofffranks/main Submodule src/idmapper a41052025..39b35b84a: > Merge pull request #71 from geofffranks/main
winkingturtle-vmw
added a commit
that referenced
this pull request
Nov 14, 2023
…ego-ssh executor inigo locket rep route-emitter Submodule src/code.cloudfoundry.org/auction cb67f2df8...a0b5f6cb4: > Add test.bash (#17) < Add test.bash Submodule src/code.cloudfoundry.org/auctioneer 53ba4c3b4...4c948374c: > With oss ci export (#16) < Regenerate expiring certs < use relative path instead of direnv Submodule src/code.cloudfoundry.org/bbs af5179eaf...709d9ebc2: > With oss ci export (#75) > Add availability zone to actual LRPs (#74) < Regenerate expiring certs < set -e to exit when something fails < Fix path < Address pathing issue with gogo protobuf generator < Fix go fmt < Remove Focus that was added for local run only < fix test to allow for one event to < SQLFLAVOR_USER->DB_USER and PASSWORD < SQLFLAVOR_USER->DB_USER and PASSWORD < SQL_FLAVOR->DB env < use relative path instead of direnv < go fmt Submodule src/code.cloudfoundry.org/buildpackapplifecycle 2c73ee370..66d4e9349: > Merge pull request #64 from cloudfoundry/with-oss-ci-export Submodule src/code.cloudfoundry.org/cacheddownloader e92422e07...bb834a3fe: > Regenerate expiring certs (#27) < Regenerate expiring certs Submodule src/code.cloudfoundry.org/diego-ssh 1126e2462...0db8c3650: > With oss ci export (#51) < Ensure GinkgoRecover in go routine < Create a new err < Fix a potential race condition < Add bin/test.bash < Check if DLL is found instead of dir < ensure ZipArchiveMode is loaded < Add bin/test.ps1 for WINPTY_DLL_DIR < remove unneeded vars < Grab a different port than other tests < use relative path instead of direnv Submodule src/code.cloudfoundry.org/executor 0c69be068...aa6d9b164: > With oss ci export (#88) < Regenerate expiring certs < Regenerate expiring certs < Address channel buffer issue test flake < Fix go fmt < Wait long enough for log to appear Submodule src/code.cloudfoundry.org/inigo 31ce39424...04c069a3b: > With oss ci export (#28) < Unlock mutex when it's returning early < ioutil->os < Skip deleting auctioneer-config for windows < Use ci's filesystem-helpers.bash < rsync with retry, because it seems flaky < Wait for mysqld to be stopped < On windows, don't wait for tmpDir to be deleted < Add progres report back < Not sure why we need to setup < Wait longer after being Killed < Revert "Send SIGINT instead of SIGKILL" < Send SIGINT instead of SIGKILL < Use ci's helper instead < Wait longer for auctioneer to have been stopped < Add a debug for envoy.exe path < Print output to stdout < Add logs.txt output to show progress < fix extra space < Swap the order for Out-File to be after Invoke-Expression < Add Encoding and Width < use correct folder name < Use a timestamp for inigo-logs < unfocus tests < Set PROXY_BINARY < Focus the failing test < Remove debug logs < Add missing -F < Invoke ginkgo < Use correct env variable < winc-> winc-network < use correct env variables < Remove unneeded function < fix tmp dir < Keep all vendored < Add test.ps1 for windows version < mkdir logs dir < Use a dir for logs < Use binaries from GARDEN_BINPATH < Add GROOTFS_BINPATH < Revert "GROOTFS_BINPATH->GROOTFS_BINARY" < GROOTFS_BINPATH->GROOTFS_BINARY < use builds from CI instead of building in the test task < Use updated docker image for dependencies < Remove packages that might not be needed < Max connection to 2000 for mysql < Use PROXY_BINARY from build-binaries task < Fix go vet issues < Use garden-runc-release's tar for rootfs < build rootfs instead of providing an OCI built one < Add more packages < Add uidmap < Add tag for gdn < symlink tar < resolve pg_cof value < user NATS_SERVER_BINARY < relative resolve pg_conf < Install required dependencies < Use env variable for garden-runc < Use correct env < {sudo,} < Add dnsmasq as a depedency < Add bin/test.bash < User DB_USER and DB_PASSWORD instead < Use correct path for finding fixtures Submodule src/code.cloudfoundry.org/locket 7a13b7b4d...23339499a: > With oss ci export (#16) < Regenerate expiring certs < set -e to exit when something fails < Fix path < Address issue with gogo protobuf generator < SQLFLAVOR_USER->DB_USER and PASSWORD Submodule src/code.cloudfoundry.org/rep b26698303...eedf2cd88: > With oss ci export (#49) > Send AZ in StartActualLRP/EvacuateRunningActualLRP requests to BBS (#48) < change db_name to a unique name < Update port ranges to use more unique number to avoid port collisions under Windows < use relative path instead of direnv Submodule src/code.cloudfoundry.org/route-emitter 828ee627e...96aae07f6: > With oss ci export (#30) > Add AZ to registry message (#29) < Modify Main test suite to use more unique database name < Use NATS_SERVER_BINARY instead < use relative path instead of direnv
3 tasks
MarcPaquette
pushed a commit
that referenced
this pull request
Nov 14, 2023
…ego-ssh executor inigo locket rep route-emitter (#859) Submodule src/code.cloudfoundry.org/auction cb67f2df8...a0b5f6cb4: > Add test.bash (#17) < Add test.bash Submodule src/code.cloudfoundry.org/auctioneer 53ba4c3b4...4c948374c: > With oss ci export (#16) < Regenerate expiring certs < use relative path instead of direnv Submodule src/code.cloudfoundry.org/bbs af5179eaf...709d9ebc2: > With oss ci export (#75) > Add availability zone to actual LRPs (#74) < Regenerate expiring certs < set -e to exit when something fails < Fix path < Address pathing issue with gogo protobuf generator < Fix go fmt < Remove Focus that was added for local run only < fix test to allow for one event to < SQLFLAVOR_USER->DB_USER and PASSWORD < SQLFLAVOR_USER->DB_USER and PASSWORD < SQL_FLAVOR->DB env < use relative path instead of direnv < go fmt Submodule src/code.cloudfoundry.org/buildpackapplifecycle 2c73ee370..66d4e9349: > Merge pull request #64 from cloudfoundry/with-oss-ci-export Submodule src/code.cloudfoundry.org/cacheddownloader e92422e07...bb834a3fe: > Regenerate expiring certs (#27) < Regenerate expiring certs Submodule src/code.cloudfoundry.org/diego-ssh 1126e2462...0db8c3650: > With oss ci export (#51) < Ensure GinkgoRecover in go routine < Create a new err < Fix a potential race condition < Add bin/test.bash < Check if DLL is found instead of dir < ensure ZipArchiveMode is loaded < Add bin/test.ps1 for WINPTY_DLL_DIR < remove unneeded vars < Grab a different port than other tests < use relative path instead of direnv Submodule src/code.cloudfoundry.org/executor 0c69be068...aa6d9b164: > With oss ci export (#88) < Regenerate expiring certs < Regenerate expiring certs < Address channel buffer issue test flake < Fix go fmt < Wait long enough for log to appear Submodule src/code.cloudfoundry.org/inigo 31ce39424...04c069a3b: > With oss ci export (#28) < Unlock mutex when it's returning early < ioutil->os < Skip deleting auctioneer-config for windows < Use ci's filesystem-helpers.bash < rsync with retry, because it seems flaky < Wait for mysqld to be stopped < On windows, don't wait for tmpDir to be deleted < Add progres report back < Not sure why we need to setup < Wait longer after being Killed < Revert "Send SIGINT instead of SIGKILL" < Send SIGINT instead of SIGKILL < Use ci's helper instead < Wait longer for auctioneer to have been stopped < Add a debug for envoy.exe path < Print output to stdout < Add logs.txt output to show progress < fix extra space < Swap the order for Out-File to be after Invoke-Expression < Add Encoding and Width < use correct folder name < Use a timestamp for inigo-logs < unfocus tests < Set PROXY_BINARY < Focus the failing test < Remove debug logs < Add missing -F < Invoke ginkgo < Use correct env variable < winc-> winc-network < use correct env variables < Remove unneeded function < fix tmp dir < Keep all vendored < Add test.ps1 for windows version < mkdir logs dir < Use a dir for logs < Use binaries from GARDEN_BINPATH < Add GROOTFS_BINPATH < Revert "GROOTFS_BINPATH->GROOTFS_BINARY" < GROOTFS_BINPATH->GROOTFS_BINARY < use builds from CI instead of building in the test task < Use updated docker image for dependencies < Remove packages that might not be needed < Max connection to 2000 for mysql < Use PROXY_BINARY from build-binaries task < Fix go vet issues < Use garden-runc-release's tar for rootfs < build rootfs instead of providing an OCI built one < Add more packages < Add uidmap < Add tag for gdn < symlink tar < resolve pg_cof value < user NATS_SERVER_BINARY < relative resolve pg_conf < Install required dependencies < Use env variable for garden-runc < Use correct env < {sudo,} < Add dnsmasq as a depedency < Add bin/test.bash < User DB_USER and DB_PASSWORD instead < Use correct path for finding fixtures Submodule src/code.cloudfoundry.org/locket 7a13b7b4d...23339499a: > With oss ci export (#16) < Regenerate expiring certs < set -e to exit when something fails < Fix path < Address issue with gogo protobuf generator < SQLFLAVOR_USER->DB_USER and PASSWORD Submodule src/code.cloudfoundry.org/rep b26698303...eedf2cd88: > With oss ci export (#49) > Send AZ in StartActualLRP/EvacuateRunningActualLRP requests to BBS (#48) < change db_name to a unique name < Update port ranges to use more unique number to avoid port collisions under Windows < use relative path instead of direnv Submodule src/code.cloudfoundry.org/route-emitter 828ee627e...96aae07f6: > With oss ci export (#30) > Add AZ to registry message (#29) < Modify Main test suite to use more unique database name < Use NATS_SERVER_BINARY instead < use relative path instead of direnv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#88945102]
Signed-off-by: Ben_Moss bmoss@pivotal.io