Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Container Infrastructure. #395

Closed
wants to merge 1 commit into from
Closed

Virtual Container Infrastructure. #395

wants to merge 1 commit into from

Conversation

andyliuliming
Copy link

This is for virtual container infrastructure support.
say, use the Azure Container Instances as the Container Provider.

@cfdreddbot
Copy link

Hey andyliuliming!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/158054290

The labels on this github issue will be updated when the story is started.

@emalm
Copy link
Member

emalm commented Jun 7, 2018

Hi, @andyliuliming,

Could you give us on the Diego team more information on what goals you would like to achieve with the changes in this PR and the associated component PRs (cloudfoundry/executor#32, cloudfoundry/rep#22) and why those goals are valuable? This changes looks like they would introduce a substantially new set of functionality, and so before we even consider incorporating them we would like to know more about the problems they solve, as well as to discuss the technical approach with you.

Additionally, these PRs include no changes to any of the Diego test suites, which is the primary way we have to understand what you intend these changes to do and to validate that they indeed work correctly.

Thanks,
Eric, CF Diego PM

Callisto13 pushed a commit to masters-of-cats/diego-release that referenced this pull request Jul 27, 2018
@sjolicoeur @nimakaviani
bump image
538f9f2 
[finishes #154404094]

Submodule src/github.com/containers/image 4fdf9c9b8..495da41bd:
  > Merge pull request cloudfoundry#402 from yulianedyalkova/master
  > Merge pull request cloudfoundry#404 from mtrmac/golang-update
  > Merge pull request cloudfoundry#403 from mtrmac/ci-update
  > Merge pull request cloudfoundry#401 from giuseppe/fix-ostree-uncompressed-layers-pull
  > Merge pull request cloudfoundry#390 from ripcurld0/errors_cause_for_download
  > Merge pull request cloudfoundry#399 from nalind/tarball-readonly
  > Merge pull request cloudfoundry#398 from nalind/version-permission-bits
  > Merge pull request cloudfoundry#395 from nstack/master

Signed-off-by: Nima Kaviani <nkavian@us.ibm.com>
@emalm
Copy link
Member

emalm commented Jul 31, 2018

Closing due to inactivity. If you're still interested in pursuing these enhancements, @andyliuliming, feel free to open a GitHub issue for discussion with the team.

Thanks again,
Eric

@emalm emalm closed this Jul 31, 2018
This was referenced Jul 31, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andyliuliming @cfdreddbot @cf-gitbot @emalm