Correct route_emitter health check address description #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey benjaminguttmann-avtq! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/159430415 The labels on this github issue will be updated when the story is started. |
caod123
pushed a commit
to caod123/diego-release
that referenced
this pull request
Jul 31, 2018
[finishes #154404094] Submodule src/github.com/containers/image 4fdf9c9b8..495da41bd: > Merge pull request cloudfoundry#402 from yulianedyalkova/master > Merge pull request cloudfoundry#404 from mtrmac/golang-update > Merge pull request cloudfoundry#403 from mtrmac/ci-update > Merge pull request cloudfoundry#401 from giuseppe/fix-ostree-uncompressed-layers-pull > Merge pull request cloudfoundry#390 from ripcurld0/errors_cause_for_download > Merge pull request cloudfoundry#399 from nalind/tarball-readonly > Merge pull request cloudfoundry#398 from nalind/version-permission-bits > Merge pull request cloudfoundry#395 from nstack/master Signed-off-by: Nima Kaviani <nkavian@us.ibm.com>
caod123
pushed a commit
to caod123/diego-release
that referenced
this pull request
Jul 31, 2018
Submodule src/code.cloudfoundry.org/executor 23ff7f34..08a81a58: > use the new gomega Receive matcher to cleanup the tests Submodule src/github.com/onsi/ginkgo 67b9df7f5..c73579c58: > Increase eventually timeout to 30s > Clarify asynchronous test behaviour > Travis badge should only show master > v1.5.0 > Bring the changelog up to date (cloudfoundry#470) > Merge pull request cloudfoundry#466 from onsi/issue-464 > Merge pull request cloudfoundry#468 from onsi/update-changelog > Merge pull request cloudfoundry#459 from onsi/unfocus-exclude-vendor > Merge pull request cloudfoundry#456 from idoru/ignore-suite-with-ignored-go-files > Merge pull request cloudfoundry#455 from onsi/flaky-measurements > Merge pull request cloudfoundry#423 from alamages/coverage-tests-fix > Add go 1.10 to travis > Merge pull request cloudfoundry#448 from melnikk/master > Merge pull request cloudfoundry#451 from onsi/go-1.10-coverage-test > Merge pull request cloudfoundry#446 from onsi/do-not-create-outputdir > Add an extra new line after reporting spec run completion > Merge pull request cloudfoundry#441 from blgm/releasing > Merge pull request cloudfoundry#443 from onsi/add-go-1.10 > Merge pull request cloudfoundry#438 from onsi/issue-436 > Merge pull request cloudfoundry#434 from mezis/blur-specify > Merge pull request cloudfoundry#430 from onsi/issue-426 > Add tests for When/Specify > Update comments and README.md for `When` DSL > Merge pull request cloudfoundry#386 from akshaymankar/when > Merge pull request cloudfoundry#383 from eloycoto/master > fix the tests on go versions <1.9 > add a test case for cloudfoundry#415 > Fix Ginkgo stack trace on failure for Specify > Merge pull request cloudfoundry#409 from lflux/readme-update > Merge pull request cloudfoundry#400 from alex-slynko/patch-1 > Merge pull request cloudfoundry#403 from alex-slynko/fix_govet > Merge pull request cloudfoundry#404 from lflux/travis-go-1.9 > Merge pull request cloudfoundry#399 from alex-slynko/fix_imports > Merge pull request cloudfoundry#401 from alex-slynko/patch-2 > Merge pull request cloudfoundry#398 from martinxsliu/generated-import-ordering > Merge pull request cloudfoundry#390 from DennisDenuto/master > Re-add noisySkippings flag > Replace GOPATH in Environment > Allow coverage to be displayed for focused specs (cloudfoundry#367) > ensure customer reporters are run before default reporter > Handle -outputdir flag (cloudfoundry#364) > Handle -coverprofile flag (cloudfoundry#355) > v1.4.0 > v1.4.0 > fix CONTRIBUTING.md > Add a CONTRIBUTING.md file > add -timeout flag. fixes cloudfoundry#248 > add 'requireSuite' flag to cause failure if there are test files but no suite (cloudfoundry#359) > update changelog > emit compilation output > link to vscode extension > add ginkgo watch -watchRegExp fixes cloudfoundry#356 > remove fixCompilationOutput (fixes cloudfoundry#357) > Remove mailing list > Add Rick and Morty quote to untilItFails messages (cloudfoundry#354) > Revert "Fix wrong repo URL (cloudfoundry#351)" (cloudfoundry#352) > Fix wrong repo URL (cloudfoundry#351) > Lack of test suites no longer breaks builds (cloudfoundry#347) > Update CHANGELOG.md > Warn when a suite has test files but no tests to run (cloudfoundry#345) > fix flaky test by, you know, not relying on obscure go internals > update .travis.yml to get latest patch releases > fix failing go 1.5 tests > ensure tests pass on Go 1.8.1 > v1.3.1: Actually change the CLI version > print location of test suite that failed to report back (cloudfoundry#339) > v1.3.0 Submodule src/github.com/onsi/gomega 777f4d387..41673fd8f: > allow 'Receive' matcher to be used with concrete types (cloudfoundry#286) > Fix data race in ghttp server (cloudfoundry#283) > Travis badge should only show master > v1.4.0 > Update the CHANGELOG.md with all changes since last release > Improve message from AssignableToTypeOf when expected value is nil (cloudfoundry#281) > Merge pull request cloudfoundry#278 from benmoss/master > Merge pull request cloudfoundry#273 from vayan/master > change Ω to Expect in most places (cloudfoundry#268) > Merge pull request cloudfoundry#272 from trayo/master > Merge pull request cloudfoundry#271 from onsi/add-go-1.10 > Merge pull request cloudfoundry#270 from Patagonicus/master > Remove tests that tried to verify signals as async > Merge pull request cloudfoundry#262 from onsi/issue-173 > Merge pull request cloudfoundry#259 from onsi/issue-258 > v1.3.0 > Add more robust support for XUnit style tests > Merge pull request cloudfoundry#256 from onsi/allow-multiple-go-routines > Merge pull request cloudfoundry#253 from challiwill/master > Merge pull request cloudfoundry#249 from alex-slynko/fix_govet > Merge pull request cloudfoundry#247 from alex-slynko/fix_imports > Merge pull request cloudfoundry#243 from williammartin/find-first-mismatch-oob > Merge pull request cloudfoundry#241 from ivy/fix-typos > Merge pull request cloudfoundry#218 from alex-slynko/patch-1 > Merge pull request cloudfoundry#239 from williammartin/parallel-testing > Merge pull request cloudfoundry#235 from onsi/fix-227 > MatchXML should ignore the order of xml node attributes > Merge pull request cloudfoundry#233 from kaedys/bugfix/error-matcher-fix > Uses equality matcher for matching error strings Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
|
Thanks for the correction, @benjaminguttmann-avtq ! Seems reasonable; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects C&P description for route_emitter health_check address