Combine helm subcharts into single chart #2052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1904
What is this change about?
Use a single
controllers
deployment that runs all Korifi reconcilers insteadof having multiple deployments
api
,controllers
statefulset-runner
,job-task-runner
,kpack-image-builder
components that can be switched offvia the helm values file. If a component is disabled, the related templates
are simply not rendered.
statefulset-runner
,job-task-runner
,kpack-image-builder
are no longer needed and are therefore deletedDoes this PR introduce a breaking change?
Yes, "top-level" values are now camel-cased instead of snake-cased:
statefulset-runner
->statefulsetRunner
kpack-image-builder
->kpackImageBuilder
job-task-runner
->jobTaskRunner
Acceptance Steps
api
andcontrollers
Tag your pair, your PM, and/or team
@georgethebeatle @gcapizzi @kieron-dev