Combine helm subcharts into single chart #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
approved these changes
Jan 10, 2023
danail-branekov
force-pushed
the
issues/1904-single-controller-deployment
branch
2 times, most recently
from
d62253f
to
70cfe05
Compare
Issue: #1904 Co-authored-by: Kieron Browne <kbrowne@vmware.com> Co-authored-by: Giuseppe Capizzi <gcapizzi@vmware.com> Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
danail-branekov
force-pushed
the
issues/1904-single-controller-deployment
branch
from
70cfe05
to
f9b39c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1904
What is this change about?
Use a single
controllersdeployment that runs all Korifi reconcilers insteadof having multiple deployments
api,controllersstatefulset-runner,job-task-runner,kpack-image-buildercomponents that can be switched offvia the helm values file. If a component is disabled, the related templates
are simply not rendered.
statefulset-runner,job-task-runner,kpack-image-builderare no longer needed and are therefore deletedDoes this PR introduce a breaking change?
Yes, "top-level" values are now camel-cased instead of snake-cased:
statefulset-runner->statefulsetRunnerkpack-image-builder->kpackImageBuilderjob-task-runner->jobTaskRunnerAcceptance Steps
apiandcontrollersTag your pair, your PM, and/or team
@georgethebeatle @gcapizzi @kieron-dev