Fix app deletion when updating route destinations #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We only need to validate the domain on route creation as we do not allow users to change the domain reference on an existing route. [#2705]
tcdowney
reviewed
Jul 18, 2023
tcdowney
approved these changes
Jul 18, 2023
matt-royal
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2705
What is this change about?
This PR updates the route validator to only validate that a domain exists on creation. We only need to validate the domain on route creation as we do not allow users to change the domain reference on an existing route. Validating the existence of the domain on update can block app deletion if the domain has already been deleted.
Does this PR introduce a breaking change?
No.
Acceptance Steps
See the A/C in the issue.
Tag your pair, your PM, and/or team
@matt-royal