Support converting http timers to OTel traces #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctlong
previously approved these changes
Apr 15, 2024
Forwarder Agent forwards loggregator timers to OTel Collectors as OTLP traces. Signed-off-by: Andrew Crump <andrew.crump@broadcom.com> Signed-off-by: Rebecca Roberts <rebecca.roberts@broadcom.com> Signed-off-by: Matthew Kocher <matthew.kocher@broadcom.com>
- Adds temporary_emit_otel_traces property to forwarder agent to control whether to convert timers to traces and emit to OTel Collector. - Default to false until we have more experience with this feature being activated. - An alternative implementation would be to allow each destination to configure the types of envelopes it would like to receive, which seemed unnecessarily complex.
acrmp
force-pushed
the
otel-collector-client-timer-support
branch
from
1d4676c
to
baf8617
Compare
ctlong
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support in Forwarder Agent for converting timers tagged with trace and span ids to OpenTelemetry traces. Feature is optional and currently not active by default.
temporary_emit_otel_tracesproperty controls whether the Forwarder Agent converts timers to traces. An alternative implementation approach would have been to allow the ingress config for each consumer to declare that it wanted this feature enabled. The property was added to the Windows job for consistency although we don't expect it to be receiving http timers.service.nameattribute to be defined at the resource level. However it's not currently possible to configure the span metrics connector in otel-collector-release.Depends on this gorouter change: cloudfoundry/gorouter#407
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack