-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change postgres version from 11.10 to 11.15 #62
Change postgres version from 11.10 to 11.15 #62
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/181793824 The labels on this github issue will be updated when the story is started. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the change looks good. What I found is that the versions.yml needs to be updated and please check my other comment for the blobls.yml.
config/blobs.yml
Outdated
@@ -6,3 +6,6 @@ postgres/postgresql-11.10.tar.gz: | |||
size: 26206541 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the blobs for postgresql-11.10.tar.gz
weren't remove when they aren't referenced any more in the bosh release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed the unused blob. Regarding the versions.yml: We noticed that the versions.yml is being taken care of from the create-final-release
task/pipeline. Is this pipeline part of some release process that is triggered after a successful merge? If so, who is responsible for that pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar how the release setup is done for this project. @rkoster do you know? It looks to me that:
- we shouldn't change
blobs.yml
manually. This should happen during thebosh upload-blobs
. Sorry, I missed this during the first review - the blob for the new release needs to uploaded manually
- the create-final-release task will create the final release and add its version to the
versions.yml
but doesn't upload any blobs. - The old part in the
versions.yml
is maintained manually.
Thanks! @fhambrec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The latest minor version of postgresql v11 is 15. This pull request bumps the postgres version of this bosh release from 11.10 to 11.15 and exchanges all related spec/package files and folders. To enable the usage of the new release the postgres11.15-archive needs to be added to the official blobstore.