Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable http2 cats #218

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

mkocher
Copy link
Member

@mkocher mkocher commented Sep 13, 2021

  • added the flag to turn on http2 cats in the routing pipeline
  • sorted the keys to leave the file better than we found it

Signed-off-by: Michael Oleske moleske@vmware.com

  • A short explanation of the proposed change:

Turn on the property that enables h2 cats

  • An explanation of the use cases your change solves

We want to run the h2 cats in CI now that h2 is going to be generally available and is on by default.

  • Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)

Look at the cats output and see that the h2 tests are running.

  • Expected result after the change

They will be running

  • Current result before the change

They won't be running

  • Links to any other associated PRs

#200

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run all the unit tests using scripts/run-unit-tests-in-docker

  • (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite

  • (Optional) I have run CF Acceptance Tests on bosh lite

- added the flag to turn on http2 cats in the routing pipeline
- sorted the keys to leave the file better than we found it

Signed-off-by: Michael Oleske <moleske@vmware.com>
@mkocher
Copy link
Member Author

mkocher commented Sep 13, 2021

This PR might be necessary for this to go green in CI, hopefully it'll be merged real quick now - cloudfoundry/cf-acceptance-tests#479

@reneighbor reneighbor merged commit 02039bc into cloudfoundry:develop Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants