Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tls_handshake_timeout paramter to override the default 10 seconds #239

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

ywei2017
Copy link
Contributor

  • A short explanation of the proposed change:
    Add tls_handshake_timeout so it can be configured

  • An explanation of the use cases your change solves:
    When the diego_cells go through vSphere vMotion, there is a stun time (like the VM is frozen). When that happens, new gorouter connections to the diego_cell will timeout after 10 seconds. The parameter will allow us to shorten the timeout, so gorouter would attempt another diego_cell, mitigating the long wait (or 499 errors) on the clients.

  • Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
    Inspect /var/vcap/jobs/gorouter/config/gorouter.yml. When the parameter is not provided, it should say "tls_handshake_timeout: 10s"; or whatever value is provided by the operator.

  • Expected result after the change
    Gorouter clients see faster response time during vMotion, or fewer 499 erros

  • Current result before the change
    Gorouter clients experience timeouts.

  • Links to any other associated PRs
    N/A

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run all the unit tests using scripts/run-unit-tests-in-docker

  • (Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite

  • (Optional) I have run CF Acceptance Tests on bosh lite

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2021

CLA Signed

The committers are authorized under a signed CLA.

@geofffranks
Copy link
Contributor

Thanks @ywei2017 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants