Add tls_handshake_timeout paramter to override the default 10 seconds #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add tls_handshake_timeout so it can be configured
An explanation of the use cases your change solves:
When the diego_cells go through vSphere vMotion, there is a stun time (like the VM is frozen). When that happens, new gorouter connections to the diego_cell will timeout after 10 seconds. The parameter will allow us to shorten the timeout, so gorouter would attempt another diego_cell, mitigating the long wait (or 499 errors) on the clients.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
Inspect /var/vcap/jobs/gorouter/config/gorouter.yml. When the parameter is not provided, it should say "tls_handshake_timeout: 10s"; or whatever value is provided by the operator.
Expected result after the change
Gorouter clients see faster response time during vMotion, or fewer 499 erros
Current result before the change
Gorouter clients experience timeouts.
Links to any other associated PRs
N/A
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
develop
branchI have run all the unit tests using
scripts/run-unit-tests-in-docker
(Optional) I have run Routing Acceptance Tests and Routing Smoke Tests on bosh lite
(Optional) I have run CF Acceptance Tests on bosh lite