Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tls_handshake_timeout paramter to override the default 10 seconds #239

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Add tls_handshake_timeout paramter to override the default 10 seconds #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2925f50
Add tls_handshake_timeout paramter to override the default 10 seconds
ywei2017 Oct 25, 2021
79821a9
Merge branch 'develop' of https://github.com/cloudfoundry/routing-rel…
ywei2017 Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ rubocop ./spec/

If you do not have `rspec` or `rubocop` installed locally, run
`./scripts/start-docker-for-testing.sh` and execute the commands in the docker
container.
container. Prepend "sudo" to he script if you are an unpreviledged user.



#### <a name="running-unit-and-integration-tests"></a> Running Unit and Integration Tests
Expand All @@ -121,7 +122,7 @@ container.
runs unit *and* integration tests, that's why they need to run in a container.

```bash
./scripts/run-unit-tests-in-docker
./scripts/run-unit-tests-in-docker #sudo for unpreviledged users
```

* If you'd like to run a specific component's tests in a Docker container,
Expand Down
6 changes: 6 additions & 0 deletions jobs/gorouter/spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,12 @@ properties:
and `router.keep_alive_probe_interval`.
default: 900

tls_handshake_timeout_in_seconds:
description: |
Maximum time in seconds for gorouter to establish a TLS connection with a backend container. This timeout is for establishing
the TLS connection only. Actual HTTP request timeout is defined by `router.request_timeout_in_seconds`.
default: 10

metron.port:
description: "The port used to emit dropsonde messages to the Metron agent."
default: 3457
Expand Down
1 change: 1 addition & 0 deletions jobs/gorouter/templates/gorouter.yml.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ params = {
'drain_timeout' => "#{p('router.drain_timeout')}s",
'healthcheck_user_agent' => p('router.healthcheck_user_agent'),
'endpoint_timeout' => "#{p('request_timeout_in_seconds')}s",
'tls_handshake_timeout' => "#{p('tls_handshake_timeout_in_seconds')}s",
'start_response_delay_interval' => "#{p('router.requested_route_registration_interval_in_seconds')}s",
'load_balancer_healthy_threshold' => "#{p('router.load_balancer_healthy_threshold')}s",
'balancing_algorithm' => p('router.balancing_algorithm'),
Expand Down