This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 131
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge downstream - JSON Viewer with dark mode & Header Fixes (#4444)
* Fix json-viewer dark mode * Fix profile page and side nav top position following header diet - Fix side nav top position - Update fix for profile page to also work in non-desktop mode
- Loading branch information
1 parent
dd34fc5
commit 244f9fe
Showing
4 changed files
with
27 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...frontend/packages/core/src/shared/components/json-viewer/json-viewer.component.theme.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
@mixin app-json-view-theme($theme, $app-theme) { | ||
$is-dark: map-get($theme, is-dark); | ||
|
||
@if $is-dark == true { | ||
// Keep this simple, otherwise there's a LOT of overrides. | ||
// Additionally would need to bring in the non-dark mode colours to ensure the selectors work | ||
app-json-viewer { | ||
// There can be child json-viewers, ensure this only applies to the top level | ||
&:not([root='false']) { | ||
background-color: #ffffffeb; | ||
border-radius: 3px; | ||
} | ||
} | ||
} | ||
} |