Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Commit

Permalink
Ensure we filter out maxed results for local lists
Browse files Browse the repository at this point in the history
- When apps collection is fetched and exceeds maxed allowed certain monitor observables were still firing with the partial collection of apps
- This led to app based stats (like count and memory) to be shown on the space cards & summary
- This was caused by a correction to the pagination monitor to use 'local' monitor observables instead of non-local
- The now correct observable to use did not have a filter for maxed results, so emited the bad data
  • Loading branch information
richard-cox committed Apr 28, 2020
1 parent af4dd5c commit 403e9e0
Showing 1 changed file with 1 addition and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ export class PaginationMonitor<T = any, Y extends AppState = GeneralEntityAppSta
distinctUntilChanged(),
// Improve efficiency
observeOn(asapScheduler),
filter(pagination => this.hasPage(pagination) && !LocalPaginationHelpers.isPaginationMaxed(pagination)),
combineLatestOperator(entityObservable$),
withLatestFrom(allEntitiesObservable$),
map(([[pagination], allEntities]) => {
Expand Down

0 comments on commit 403e9e0

Please sign in to comment.