Remove use of nodejs util module (#4521)

* Remove use of nodejs util module * Fix comment typo
cloudfoundry · Aug 21, 2020 · 9a70ea6 · 9a70ea6
1 parent 286d508
commit 9a70ea6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 9 deletions.
diff --git a/src/frontend/packages/store/src/reducers/api-request-reducer/fail-request.ts b/src/frontend/packages/store/src/reducers/api-request-reducer/fail-request.ts
@@ -1,7 +1,6 @@
-import { isNullOrUndefined } from 'util';
-
 import { BaseEntityRequestAction } from '../../entity-catalog/action-orchestrator/action-orchestrator';
 import { IFailedRequestAction } from '../../types/request.types';
+import { isNullOrUndefined } from '../../utils';
 import { getEntityRequestState, mergeUpdatingState, setEntityRequestState } from './request-helpers';
 
 export function failRequest(state, action: IFailedRequestAction) {

diff --git a/src/frontend/packages/store/src/reducers/api-request-reducer/start-request.ts b/src/frontend/packages/store/src/reducers/api-request-reducer/start-request.ts
@@ -1,7 +1,6 @@
-import { isNullOrUndefined } from 'util';
-
 import { BaseEntityRequestAction } from '../../entity-catalog/action-orchestrator/action-orchestrator';
 import { IStartRequestAction } from '../../types/request.types';
+import { isNullOrUndefined } from '../../utils';
 import {
   getEntityRequestState,
   mergeUpdatingState,

diff --git a/src/frontend/packages/store/src/reducers/api-request-reducer/succeed-request.ts b/src/frontend/packages/store/src/reducers/api-request-reducer/succeed-request.ts
@@ -1,9 +1,8 @@
-import { isNullOrUndefined } from 'util';
-
 import { BaseRequestState } from '../../app-state';
 import { BaseEntityRequestAction } from '../../entity-catalog/action-orchestrator/action-orchestrator';
 import { mergeState } from '../../helpers/reducer.helper';
 import { ISuccessRequestAction, WrapperRequestActionSuccess } from '../../types/request.types';
+import { isNullOrUndefined } from '../../utils';
 import {
   createRequestStateFromResponse,
   getEntityRequestState,

diff --git a/src/frontend/packages/store/src/reducers/api-request-reducer/update-request.ts b/src/frontend/packages/store/src/reducers/api-request-reducer/update-request.ts
@@ -1,8 +1,7 @@
-import { isNullOrUndefined } from 'util';
-
-import { BaseEntityRequestAction } from '../../entity-catalog/action-orchestrator/action-orchestrator';
 import { BaseRequestState } from '../../app-state';
+import { BaseEntityRequestAction } from '../../entity-catalog/action-orchestrator/action-orchestrator';
 import { IUpdateRequestAction } from '../../types/request.types';
+import { isNullOrUndefined } from '../../utils';
 import { getEntityRequestState, mergeUpdatingState, setEntityRequestState } from './request-helpers';
 
 export function updateRequest(state: BaseRequestState, action: IUpdateRequestAction) {

diff --git a/src/frontend/packages/store/src/utils.ts b/src/frontend/packages/store/src/utils.ts
@@ -0,0 +1,6 @@
+// We don't want to bring in the utils package from nodejs
+// We only use this one function:
+
+export function isNullOrUndefined(obj: any): boolean {
+  return typeof obj === 'undefined' || obj === null;
+}