Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Deploy application via docker image #4025

Closed
richard-cox opened this issue Nov 28, 2019 · 1 comment · Fixed by #4069
Closed

Deploy application via docker image #4025

richard-cox opened this issue Nov 28, 2019 · 1 comment · Fixed by #4069

Comments

@richard-cox
Copy link
Contributor

  • this should be pretty straight forward
  • we should check the feature flag diego_docker is enabled (should also consider eirini flags)
@richard-cox
Copy link
Contributor Author

Need to decide if this process should be either

  1. A new deployment source which provides an app name and docker image

    • Requires some medium changes in the backend
    • Attempting to push again after failure would result in route taken errors
  2. As an option in the overrides screen override value

    • User would still need to provide source (github, upload, etc)
    • docker image is an additional option in the overrides page

In both cases we'd supply the --docker-image option to the cf push command

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant