Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix TCP route creation and improve UI #2388

Merged
merged 8 commits into from
Jun 18, 2018
Merged

Fix TCP route creation and improve UI #2388

merged 8 commits into from
Jun 18, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 14, 2018

Fixes #2344

@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nwmac nwmac self-assigned this Jun 14, 2018
@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #2388 into v2-master will increase coverage by 0.06%.
The diff coverage is 68.6%.

@@              Coverage Diff              @@
##           v2-master    #2388      +/-   ##
=============================================
+ Coverage      70.98%   71.05%   +0.06%     
=============================================
  Files            581      583       +2     
  Lines          24325    24450     +125     
  Branches        5452     5482      +30     
=============================================
+ Hits           17268    17372     +104     
- Misses          7057     7078      +21

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tweaked the text + sneaked in the http path '/' check. Probably should get a rubber stamp before merging

@richard-cox richard-cox added needs attention This PR needs attention and removed in review labels Jun 18, 2018
Copy link
Contributor Author

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit f4baf27 into v2-master Jun 18, 2018
@nwmac nwmac deleted the fix-tcp-routes branch June 18, 2018 12:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants