Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix errors when multiple cf's are connected as both admin and non-admin users #2409

Merged
merged 2 commits into from
Jun 18, 2018

Conversation

richard-cox
Copy link
Contributor

Connect two cloud foundry's, one as an admin and one as non-admin

Error 1 - fixes #2408

  • Visit the endpoints (any?) page and exceptions shown in log
  • Caused by assigning to null

Error 2

  • Visit cf that's connected as admin and no users are shown in user count or lists
  • Caused by failing to set admin cf permissions as initialised

…ssions error

- Connect two cloud foundry's, one as an admin one as non-admin
- Load the console at the endpoints (any?) page
- Exceptions thrown in console
…w users for admin cf

- Connect two endpoints, one admin, one not admin
- Non-admin cf will shows users correctly
- Admin would not show users correctly
- We were failing to mark the admin connected cf's permissions as initialised
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@richard-cox richard-cox self-assigned this Jun 18, 2018
@codecov
Copy link

codecov bot commented Jun 18, 2018

Codecov Report

Merging #2409 into v2-master will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #2409      +/-   ##
=============================================
- Coverage      71.11%   71.11%   -0.01%     
=============================================
  Files            582      582              
  Lines          24398    24399       +1     
  Branches        5467     5467              
=============================================
  Hits           17351    17351              
- Misses          7047     7048       +1

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@irfanhabib irfanhabib merged commit 233776c into v2-master Jun 18, 2018
@irfanhabib irfanhabib deleted the fix-error-on-mixed-admin branch June 18, 2018 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate permission bug
4 participants