Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Update the connected user roles section of store on roles change #2435

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

richard-cox
Copy link
Contributor

- includes renaming of role change actions from 'permissions' to 'roles'
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #2435 into v2-master will decrease coverage by 0.14%.
The diff coverage is 34%.

@@              Coverage Diff              @@
##           v2-master    #2435      +/-   ##
=============================================
- Coverage      70.96%   70.81%   -0.15%     
=============================================
  Files            588      589       +1     
  Lines          24703    24760      +57     
  Branches        5559     5578      +19     
=============================================
+ Hits           17530    17534       +4     
- Misses          7173     7226      +53

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richard-cox
Copy link
Contributor Author

Merging. Tests failing in master

@richard-cox richard-cox merged commit 7c93550 into v2-master Jun 20, 2018
@irfanhabib irfanhabib deleted the update-user-roles branch June 28, 2018 10:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants