Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Service Catalog UI Tweaks #2481

Merged
merged 7 commits into from
Jun 21, 2018
Merged

Service Catalog UI Tweaks #2481

merged 7 commits into from
Jun 21, 2018

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Jun 20, 2018

This PR:

  • Adds a subtle flag to the boolean indicator that switches it to use subtler colours than red/green
  • Updated service card to use this mode for bindable and active
  • Clamped the description to 3 lines with fade for overflow so that all cards are aligned
  • Moved service plan count up
  • Combined the docs and support links and refined their display
  • Improved the service card icon so that if the image fails to load we fall back to the default icon
  • Changed line height to 1.5 on the description of the service detail page to make it easier to read

Also:

  • Changed the CF Selector view to use the subtle mode and to always show if the user is an administrator of the given CF

@nwmac nwmac self-assigned this Jun 20, 2018
@cfdreddbot
Copy link

Hey nwmac!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #2481 into v2-master will not change coverage.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           v2-master   #2481   +/-   ##
=========================================
  Coverage       70.7%   70.7%           
=========================================
  Files            590     590           
  Lines          24850   24850           
  Branches        5610    5610           
=========================================
  Hits           17569   17569           
  Misses          7281    7281

@richard-cox richard-cox merged commit 2ec2d2d into v2-master Jun 21, 2018
@richard-cox richard-cox deleted the ui-tweaks branch June 21, 2018 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants