Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Improved fix for exception on org screen after fresh load on create space #2487

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

richard-cox
Copy link
Contributor

…pace

- Previous solution was sledgehammer approach which could cause extra requests
- New solution ensures we handle the 'partial' entity created better
- Probably needs explaining in person
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #2487 into v2-master will decrease coverage by <.01%.
The diff coverage is 16.66%.

@@             Coverage Diff              @@
##           v2-master   #2487      +/-   ##
============================================
- Coverage      70.71%   70.7%   -0.01%     
============================================
  Files            590     590              
  Lines          24832   24835       +3     
  Branches        5605    5606       +1     
============================================
  Hits           17559   17559              
- Misses          7273    7276       +3

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit b651e9f into v2-master Jun 21, 2018
@nwmac nwmac deleted the fix-create-space-cancel branch June 21, 2018 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants