-
Notifications
You must be signed in to change notification settings - Fork 131
Conversation
- Fixes - no users shown in ibm cloud when using https://api.<region>.bluemix.net - Fixes - in scf missmatch between user count and users in users table - Step backward - Shows three extra users in scf users table. - Two `inactive` users that do not contain a username - One 'active' user that does not contain a username and who's guid is `hcf_auto_config`
- We now ensure all users have guids, acquired from their guid - This means the hcf_auto_config user is shown again - Ensure this user is blocked, so no org/space roles can be assigned - Wired in same blocking mechanism to manager users select users step
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2496 +/- ##
=============================================
- Coverage 70.69% 70.65% -0.05%
=============================================
Files 590 590
Lines 24852 24822 -30
Branches 5611 5611
=============================================
- Hits 17569 17537 -32
- Misses 7283 7285 +2 |
const rowStateManager = new TableRowStateManager(); | ||
const sub = paginationMonitor.currentPage$.pipe( | ||
tap(users => { | ||
users.forEach(user => { | ||
rowStateManager.setRowState(user.metadata.guid, { | ||
blocked: !user.entity.username | ||
blocked: user.metadata.guid === 'hcf_auto_config' || user.metadata.guid === 'scf_auto_config' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should special-case SCF users.
- Don't make special case of auto_config user - This will only be visible to cf admins... unless they assign roles to it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
deploy/README.md
Outdated
2. Kubernetes, using a Helm chart. See [guide](kubernetes) | ||
3. Docker, using docker compose. See [guide](docker-compose) | ||
4. Docker, single container deploying all components. See [guide](all-in-one) | ||
1. Cloud Foundry, as an application. See [guide](cloud-foundry/README) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these links work with the added README - what was the reason for change? We have the same links in the main README as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ensure that all users have a username, use the guid when missing
Fixes #2463