This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Deal with non CF Jetstream failed requests #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2497 +/- ##
==========================================
Coverage 70.69% 70.69%
==========================================
Files 590 590
Lines 24852 24852
Branches 5611 5611
==========================================
Hits 17569 17569
Misses 7283 7283 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2459
errorResponseisnt set when a non-CF jetstream request is failed. Currently we throw an exception and declare all endpoints as errored.Although because of a possible subscription leak the endpoint that was disconnected still ends up in errored state. That is tracked in #2460