Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Clean entity service #2551

Merged
merged 5 commits into from
Jun 29, 2018
Merged

Clean entity service #2551

merged 5 commits into from
Jun 29, 2018

Conversation

KlapTrap
Copy link
Contributor

This will fix issues where entities were not updating in the UI correctly.

This fix has been applied to #2518 as it fixes an issue found there.
@nwmac also hit an issue that was fixed in a similar way. I have undone the change that I did for @nwmac and applied a general fix for the issue.

It shouldn't have any issues but because it's a widely used code path, we should test well.

@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@KlapTrap KlapTrap self-assigned this Jun 27, 2018
@codecov
Copy link

codecov bot commented Jun 27, 2018

Codecov Report

Merging #2551 into v2-master will increase coverage by 0.01%.
The diff coverage is 100%.

@@              Coverage Diff              @@
##           v2-master    #2551      +/-   ##
=============================================
+ Coverage      70.42%   70.43%   +0.01%     
=============================================
  Files            594      594              
  Lines          25132    25136       +4     
  Branches        5674     5673       -1     
=============================================
+ Hits           17698    17704       +6     
+ Misses          7434     7432       -2

Copy link
Contributor

@richard-cox richard-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, picked up three issues... two on master (#2559 and #2560) and one on this branch.

  • Nav to a space summary tab
  • Delete the space
  • Console fails to nav back to org spaces tab
  • Deleting a space from the org space tab works fine

@richard-cox richard-cox added the needs attention This PR needs attention label Jun 28, 2018
@KlapTrap KlapTrap added comments-addressed and removed needs attention This PR needs attention labels Jun 28, 2018
@richard-cox richard-cox merged commit 52db5c8 into v2-master Jun 29, 2018
@richard-cox richard-cox deleted the clean-entity-service branch June 29, 2018 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants