This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Fix routing to appropriate CF view after connecting/disconnecting an endpoint #2660
+19
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey irfanhabib! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2660 +/- ##
=============================================
+ Coverage 47.93% 47.94% +0.01%
=============================================
Files 597 597
Lines 25345 25350 +5
Branches 5735 5735
=============================================
+ Hits 12149 12154 +5
Misses 13196 13196 |
KlapTrap
suggested changes
Jul 6, 2018
|
|
||
| @Injectable() | ||
| export class EndpointsEffect { | ||
|
|
||
| static connectingKey = 'connecting'; | ||
| static disconnectingKey = 'disconnecting'; | ||
| static registeringKey = 'registering'; | ||
| static EndpointList = 'endpoint-list'; |
There was a problem hiding this comment.
We should make this a static on the cloud foundry service and use the same value in both places.
| @@ -132,6 +135,12 @@ export class EndpointsEffect { | |||
| ); | |||
| })); | |||
|
|
|||
| @Effect({dispatch: false}) resetEndpointsList$ = this.actions$.ofType<EndpointActionComplete>( | |||
| DISCONNECT_ENDPOINTS_SUCCESS, CONNECT_ENDPOINTS_SUCCESS).pipe( | |||
| tap(action => { | |||
There was a problem hiding this comment.
Do we need to do this now that we fixed the service?
KlapTrap
added
needs attention
irfanhabib
added
comments-addressed
and removed
needs attention
KlapTrap
approved these changes
Jul 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.