This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
- Improve typing - Move common components into new `shema-form` component - Allow users to toggle between form and text input whilst maintaining common value - Step valid state bound to type of input (form valid vs valid json) - Updated form errors to be more material like - Fixed stepper navigation (would 're-enter' last step on pressing 'next' in last step
Feature json schema
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3050 +/- ##
============================================
- Coverage 70.89% 70.79% -0.1%
============================================
Files 641 642 +1
Lines 28174 28303 +129
Branches 6405 6437 +32
============================================
+ Hits 19973 20038 +65
- Misses 8201 8265 +64 |
- Also minor tidy of json form validate
To test, update line 169 in
|
# Conflicts: # src/frontend/app/shared/components/add-service-instance/add-service-instance/add-service-instance.component.spec.ts # src/frontend/app/shared/components/add-service-instance/add-service-instance/add-service-instance.component.ts # src/frontend/app/shared/shared.module.ts
…d of both form & json options)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to original PR - See #2664
schema-form
component