This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Fix issue where only first 100 services were shown in service marketplace #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Oct 30, 2018
richard-cox
commented
- De-paginate service marketplace list by adding flattenPagination to the associated action
- Checked for other places where this might also be needed
- Ensure PaginationAction action is only used for core things
- Updated name of PaginationAction to avoid future confusion
- Use PaginatedAction as base for pagination list actions
- Ensure flattenPagination is used in service wall action (this will fetch all pages) - Ensure PaginationAction action is only used for core things
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3161 +/- ##
=============================================
+ Coverage 71.09% 71.09% +<.01%
=============================================
Files 632 632
Lines 27752 27753 +1
Branches 6314 6314
=============================================
+ Hits 19731 19732 +1
Misses 8021 8021 |
nwmac
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.