Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Deploy App: Add notification toast #3242

Merged
merged 4 commits into from
Dec 5, 2018
Merged

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Nov 25, 2018

Show notification toast when deployment completes, if the user has navigated away from the deployment UI

@nwmac nwmac self-assigned this Nov 25, 2018
@cfdreddbot
Copy link

✅ Hey nwmac! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Nov 25, 2018

Codecov Report

Merging #3242 into v2-master will decrease coverage by 0.04%.
The diff coverage is 67.05%.

@@              Coverage Diff              @@
##           v2-master    #3242      +/-   ##
=============================================
- Coverage      71.08%   71.04%   -0.05%     
=============================================
  Files            633      634       +1     
  Lines          27761    27827      +66     
  Branches        6319     6336      +17     
=============================================
+ Hits           19735    19769      +34     
- Misses          8026     8058      +32

@richard-cox richard-cox merged commit 7948017 into v2-master Dec 5, 2018
@richard-cox richard-cox deleted the deploy-app-notification branch December 5, 2018 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants