Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Env Var fix & improvements #3286

Merged
merged 6 commits into from
Jan 7, 2019
Merged

Env Var fix & improvements #3286

merged 6 commits into from
Jan 7, 2019

Conversation

richard-cox
Copy link
Contributor

  • Fix add, edit and delete env var
  • Add confirmation to delete env var
  • Add e2e tests for add, edit and delete

- Fix add, edit and delete env var
- Add confirmation to delete env var
- Add e2e tests for add, edit and delete
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Dec 13, 2018

Codecov Report

Merging #3286 into v2-master will decrease coverage by 0.04%.
The diff coverage is 67.34%.

@@              Coverage Diff              @@
##           v2-master    #3286      +/-   ##
=============================================
- Coverage      70.84%   70.79%   -0.05%     
=============================================
  Files            642      642              
  Lines          28323    28358      +35     
  Branches        6441     6447       +6     
=============================================
+ Hits           20065    20077      +12     
- Misses          8258     8281      +23

@KlapTrap KlapTrap self-requested a review January 2, 2019 11:32
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit c369f5f into v2-master Jan 7, 2019
@nwmac nwmac deleted the fix-create-env-var branch January 7, 2019 15:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants