This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Add deployment info for apps deployed via docker & fix info for local/archive apps #3291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Dec 18, 2018
richard-cox
commented
- Show deployment info for apps deployed via docker image
- Show link to docker hub image when appropriate
- Improved deployment info when loading (no flickering of title when going from no info --> have info)
- Fixed bug where apps deployed from file/archive threw exception and failed to show deploy info
- Icon needs updating with version from https://icons8.com/icon/set/docker/material
- FontForge on linux isn't behaving
- Manual c&p also failing
- Fixes App Summary: Build info should show docker info for docker apps #1709
…/archive apps - Show deployment info for apps deployed via docker image - Show link to docker hub image when appropriate - Improved dpeloyment info when loading (no flickering of title when going from no info --> have info) - Fixed bug where apps deployed from file/archive threw exception and failed to show deploy info - Icon needs updating with version from https://icons8.com/icon/set/docker/material - FontForge on linux isn't behaving - Manual c&p also failing
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3291 +/- ##
=============================================
- Coverage 70.9% 70.78% -0.13%
=============================================
Files 642 642
Lines 28204 28369 +165
Branches 6412 6450 +38
=============================================
+ Hits 19999 20081 +82
- Misses 8205 8288 +83 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.