This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Add a routes list to the CF tabs, Routes Refactor & Route Bug Fixes #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a routes list to the cf tabs
- Refactor route list config services and data sources
- Create core cf route config & data source classes. Everything will extend these
- Create app config & data source. All route lists specific to an app will extend these
- Update all routes list given teh above
- This means some tables have updated features
- additional columns
- sort by url (not by host) in all non-local
- search by url
- Fix delete app stepper routes table - routes mapped to other apps should not be deletable
- Add permissions to app route tab unmap action
- Show subtle boolean indicator for is tcp route column
- Improve error messages when unmapping a route with multiple mapped apps (so not app routes table)
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
- Code Climate fixes - Move list setup stuff out from ctor to own function - Fix spamming of route apps requests on map existing route list in create route stepper
- unmap on app routes page now works correctly - unmap on space routes page now shouldn't fire spurious action - setupList fix
Codecov Report
@@ Coverage Diff @@
## v2-master #3292 +/- ##
=============================================
+ Coverage 70.87% 71.01% +0.14%
=============================================
Files 654 658 +4
Lines 28959 29046 +87
Branches 6581 6633 +52
=============================================
+ Hits 20525 20628 +103
+ Misses 8434 8418 -16 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #3212
map existingand we previously make 1 request per route in a space. This could be a huge amount