Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix null exception after creating a space in an new org #3351

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

richard-cox
Copy link
Contributor

Other fixes

  • Found sub leak in edit org stepper
  • endpoint service allApps is subbed to in many places, ensure we share

- We previously nuked the org's space collection when creating or deleting an org
- Validation was correctly then going to refetch this list, however waitForEntity is broken (see #2327) and emits an invalid action
- Later code takes invalid action an tries to access space
- Fix, aside from #2327, is yodate org space collection after space creation instead of nuking and waiting for validation to refetch
Other fixes
- Found sub leak in edit org stepper
- endpoint service allApps is subbed to in many places, ensure we share
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #3351 into v2-master will decrease coverage by 0.01%.
The diff coverage is 20%.

@@              Coverage Diff              @@
##           v2-master    #3351      +/-   ##
=============================================
- Coverage      70.99%   70.97%   -0.02%     
=============================================
  Files            661      661              
  Lines          29170    29173       +3     
  Branches        6670     6665       -5     
=============================================
- Hits           20708    20706       -2     
- Misses          8462     8467       +5

@KlapTrap KlapTrap merged commit fde8637 into v2-master Jan 17, 2019
@nwmac nwmac deleted the blank-org-details branch June 12, 2019 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Org Summary: Not all content shown
3 participants