This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
org/space: allowed quota to be specified on creation/edition #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey vitoravelino! The commit authors and yourself have already signed the CLA. |
vitoravelino
force-pushed
the
assign-quota-org-spaces
branch
from
729f29d
to
2f4588c
Compare
Codecov Report
@@ Coverage Diff @@
## v2-master #3593 +/- ##
=============================================
- Coverage 51.84% 51.68% -0.17%
=============================================
Files 720 723 +3
Lines 20226 20381 +155
Branches 3613 3641 +28
=============================================
+ Hits 10487 10533 +46
- Misses 9739 9848 +109 |
vitoravelino
force-pushed
the
assign-quota-org-spaces
branch
3 times, most recently
from
8428c4a
to
41a2c8e
Compare
richard-cox
suggested changes
May 21, 2019
There was a problem hiding this comment.
- It looks like the create org process will always assign a quota regardless of if one is specified, so the drop down should start with the first entry selected
- If there are zero space quotas don't show the drop down in either case (not sure if this is possible for org but we should probably cover the case
- There should be a blank option in the space quota drop down that will allow the user to return to the 'none selected' state after an initial change of selection
- After creating a space with following error is shown
I can't remember if this was a previous bug or not, but it looks like whatever space is passed in comes from an entity service's action that doesn't specify the space-route inline relationship
core.js:15714 ERROR TypeError: Cannot read property 'length' of undefined at SpaceQuotaHelper._this.getOrgOrSpaceCardStatus (cloud-foundry-space-quota.ts:31) at MapSubscriber.project (cloud-foundry-org-space-quota.ts:54) - In the space summary page, when there's no space quota we take the quota limits from the org. This leads to us displaying the org quota name as the space quota. I'll fix this in this branch
...s/core/src/features/cloud-foundry/add-space/create-space-step/create-space-step.component.ts
Outdated
Show resolved
Hide resolved
...ages/core/src/features/cloud-foundry/edit-space/edit-space-step/edit-space-step.component.ts
Outdated
Show resolved
Hide resolved
...ages/core/src/features/cloud-foundry/edit-space/edit-space-step/edit-space-step.component.ts
Outdated
Show resolved
Hide resolved
Previously the org/space quotas weren't able to be selected during the creation and edition of them. The user can now select which quota definition they want. Signed-off-by: Vítor Avelino <vavelino@suse.com>
A few enhancements were done like not showing the quota field if there's no space quota and preselecting default/first org quota. Signed-off-by: Vítor Avelino <vavelino@suse.com>
vitoravelino
force-pushed
the
assign-quota-org-spaces
branch
from
4fb9f6c
to
8b082e2
Compare
When navigating directly to create/update space an exception was being thrown when the user was redirected to summary page. Signed-off-by: Vítor Avelino <vavelino@suse.com>
vitoravelino
force-pushed
the
assign-quota-org-spaces
branch
from
44284b1
to
422cd13
Compare
Combined create and edit test cases into one file and removed previous org/space manage tests. Signed-off-by: Vítor Avelino <vavelino@suse.com>
richard-cox
approved these changes
Jun 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the org/space quotas weren't able to be selected during
the creation and edition of them. The user can now select which quota
definition they want.
Signed-off-by: Vítor Avelino vavelino@suse.com
Motivation and Context
There was no way to select the org/space quota during its creation/edition.
How Has This Been Tested?
A few e2e tests.
Types of changes