Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

Fix stepper height on Chrome pre v72 & Bleeding of error style in stateful-icon #3599

Merged
merged 2 commits into from
Jun 5, 2019

Conversation

richard-cox
Copy link
Contributor

Fix stepper height on Chrome pre v72

Fix bleed of stateful-icon colours

  • the stateful-icon theme styles were beeding into others
  • seen in the endpoints card when there were connectivity and red text was shown

- pre v72 the steppers don't consume the full page
- not an issue v72 or later
- change came in after merge of downstream
- fixes #3594
@cfdreddbot
Copy link

✅ Hey richard-cox! The commit authors and yourself have already signed the CLA.

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #3599 into v2-master will decrease coverage by <.01%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           v2-master    #3599      +/-   ##
=============================================
- Coverage      51.84%   51.84%   -0.01%     
=============================================
  Files            720      720              
  Lines          20226    20226              
  Branches        3613     3613              
=============================================
- Hits           10487    10486       -1     
- Misses          9739     9740       +1

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 7a69c75 into v2-master Jun 5, 2019
@nwmac nwmac deleted the fix-stepper-chrome-bug branch June 5, 2019 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepper height broken in Chrome pre v72
3 participants