This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
Improve failed connection message for cf & metrics endpoints #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
May 20, 2019
richard-cox
commented
- previously we showed the same message regardless of type of failure
- now we show a better message for bad credentials failures
- cf - we show the specific error message (for instance 'Bad Credentials')
- metrics - we show 'unauthorised' for 401's
- previously we showed the same message regardless of type of failure - now we show a better message for bad credentials failures - cf - we show the specific error message (for instance 'Bad Credentials') - metrics - we show 'unauthorised' for 401's
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3600 +/- ##
=============================================
- Coverage 51.84% 51.84% -0.01%
=============================================
Files 720 720
Lines 20226 20226
Branches 3613 3613
=============================================
- Hits 10487 10486 -1
- Misses 9739 9740 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.